Conversation
- Bump the two public packages from 0.0.2-alpha.2 to 0.0.3-alpha.1. - Bump the scaffold's `DEFAULT_ARKOR_SPEC` (and the corresponding test expectations + override fixture filenames) to `^0.0.3-alpha.1`. CI exercises the workspace via `ARKOR_INTERNAL_SCAFFOLD_ARKOR_SPEC`, not the registry, so pre-pinning the unreleased version is safe. - Update the alpha-version callouts in the per-package READMEs and the `arkor-whoami` deprecation-warning fixture.
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📜 Recent review details⏰ Context from checks skipped due to timeout. (172)
🧰 Additional context used📓 Path-based instructions (8)**/*.md📄 CodeRabbit inference engine (AGENTS.md)
Files:
packages/*/package.json📄 CodeRabbit inference engine (AGENTS.md)
Files:
packages/arkor/package.json📄 CodeRabbit inference engine (AGENTS.md)
Files:
packages/create-arkor/package.json📄 CodeRabbit inference engine (AGENTS.md)
Files:
packages/**/*.{js,jsx,ts,tsx,mjs,cjs}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*.{js,jsx,ts,tsx,mjs,cjs}📄 CodeRabbit inference engine (CONTRIBUTING.ja.md)
Files:
e2e/cli/**/*.test.ts📄 CodeRabbit inference engine (AGENTS.md)
Files:
packages/*/src/**/*.test.ts📄 CodeRabbit inference engine (AGENTS.md)
Files:
🔇 Additional comments (7)
WalkthroughThe release version changes from ChangesVersion alignment
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review BotNo comment/code divergences or documentation drift detected. Reviewed 7 file(s); skipped 0. |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/arkorThe overall coverage remains at 99%, unchanged from the TypeScript / code-coverage/create-arkorThe overall coverage remains at 56%, unchanged from the TypeScript / code-coverage/cli-internalThe overall coverage remains at 97%, unchanged from the TypeScript / code-coverage/studio-appThe overall coverage remains at 53%, unchanged from the Updated |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
Greptile SummaryThis PR prepares the next alpha release. The main changes are:
Confidence Score: 5/5This looks safe to merge after confirming the scaffold range is intentional.
|
| Filename | Overview |
|---|---|
| packages/arkor/package.json | Bumps the published arkor package version to 0.0.3-alpha.1. |
| packages/create-arkor/package.json | Bumps the published create-arkor package version to 0.0.3-alpha.1. |
| packages/cli-internal/src/scaffold.ts | Updates the default scaffolded arkor dependency range to ^0.0.3-alpha.1. |
| packages/cli-internal/src/scaffold.test.ts | Updates scaffold expectations and override fixture strings for the new alpha version. |
| e2e/cli/src/arkor-whoami.test.ts | Updates the mocked deprecation warning fixture to the new SDK version. |
| packages/arkor/README.md | Updates the alpha status callout to 0.0.3-alpha.1. |
| packages/create-arkor/README.md | Updates the alpha status callout to 0.0.3-alpha.1. |
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/cli-internal/src/scaffold.ts:136
**Prerelease Range Can Drift**
When a new project is scaffolded without `ARKOR_INTERNAL_SCAFFOLD_ARKOR_SPEC`, this default writes a caret prerelease range into `devDependencies`. Package managers can later resolve that range to a newer `0.0.3` release than the exact alpha this scaffolder was released and tested with, so a fresh install can silently use SDK code that does not match this `create-arkor` build.
Reviews (1): Last reviewed commit: "chore: release arkor + create-arkor 0.0...." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const AGENTS_MD_PATH = "AGENTS.md"; | ||
| const CLAUDE_MD_PATH = "CLAUDE.md"; | ||
| const DEFAULT_ARKOR_SPEC = "^0.0.2-alpha.2"; | ||
| const DEFAULT_ARKOR_SPEC = "^0.0.3-alpha.1"; |
Contributor
There was a problem hiding this comment.
When a new project is scaffolded without ARKOR_INTERNAL_SCAFFOLD_ARKOR_SPEC, this default writes a caret prerelease range into devDependencies. Package managers can later resolve that range to a newer 0.0.3 release than the exact alpha this scaffolder was released and tested with, so a fresh install can silently use SDK code that does not match this create-arkor build.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/cli-internal/src/scaffold.ts
Line: 136
Comment:
**Prerelease Range Can Drift**
When a new project is scaffolded without `ARKOR_INTERNAL_SCAFFOLD_ARKOR_SPEC`, this default writes a caret prerelease range into `devDependencies`. Package managers can later resolve that range to a newer `0.0.3` release than the exact alpha this scaffolder was released and tested with, so a fresh install can silently use SDK code that does not match this `create-arkor` build.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arkor,create-arkor) from0.0.2-alpha.2to0.0.3-alpha.1. Minor bump resets the prerelease counter.DEFAULT_ARKOR_SPECin packages/cli-internal/src/scaffold.ts (and the corresponding test expectations + override fixture filenames) to^0.0.3-alpha.1. CI exercises the workspace viaARKOR_INTERNAL_SCAFFOLD_ARKOR_SPEC, not the registry, so pre-pinning the unreleased version is safe.arkor-whoamideprecation-warning fixture.Test plan
pnpm --filter @arkor/cli-internal testpasses (scaffold tests assert^0.0.3-alpha.1)arkorfrom the workspacepackages/arkordirectory viaARKOR_INTERNAL_SCAFFOLD_ARKOR_SPECv0.0.3-alpha.1and running release.yaml:npm view [email protected] dist.attestations.provenancereturns SLSA v1 provenancenpm pack [email protected] && tar -xzf arkor-0.0.3-alpha.1.tgz && grep -oE 'phc_[A-Za-z0-9_-]+' package/dist/bin.mjsreturns the configured PostHog project keyREADME.ja.md,CONTRIBUTING.md,LICENSE.md,README.md,docs/latestafter release:npm dist-tag add [email protected] latest && npm dist-tag add [email protected] latestSummary by cubic
Release
arkorandcreate-arkor0.0.3-alpha.1 and align the scaffold to use this version by default. New projects now pin^0.0.3-alpha.1, and docs/tests reflect the bump.arkorandcreate-arkorto0.0.3-alpha.1.DEFAULT_ARKOR_SPECto^0.0.3-alpha.1and adjusted scaffold tests and override fixture filenames to match (ARKOR_INTERNAL_SCAFFOLD_ARKOR_SPEC).arkor-whoamideprecation-warning fixture.Written for commit 90e26b7. Summary will update on new commits.
Summary by CodeRabbit
New Features
0.0.3-alpha.1.Bug Fixes
Documentation
0.0.3-alpha.1alpha release.