refactor(login): replaced icon, improved strings and animations#62
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Small login-screen polish: swaps the timer icon for the launcher icon, extracts the API-token helper text into translatable string resources, and adds Material fade-through transitions to LoginFragment.
Changes:
- Replace
ic_timerwith@mipmap/ic_launcheras the login logo and drop theapp:tint. - Move the hard-coded "Found in Web App > Settings > API" helper text into
login_token_helper(en + no), correcting the wording to "Account > API". - Add
MaterialFadeThroughenter/exit/reenter/return transitions toLoginFragment.onCreate.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds new login_token_helper string. |
| app/src/main/res/values-no/strings.xml | Adds Norwegian translation of login_token_helper. |
| app/src/main/res/layout/fragment_login.xml | Uses launcher icon for logo; references new helper string. |
| app/src/main/java/net/ardevd/tagius/features/auth/ui/LoginFragment.kt | Adds Material fade-through fragment transitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.