fix: Correct test cases and audit commands for rh-1.8, cis-1.11, gke-1.8.0, and eks-1.7.0 benchmarks - #1988
Conversation
amitk1sharma
changed the title
|
Hi @afdesk @mozillazg , Could you please review this PR when you get a chance? |
|
@amitk1sharma thanks a lot for your efforts! |
|
@mozillazg @LaibaBareera Could you pls take a look at this great job too? |
mozillazg
left a comment
mozillazg
left a comment
There was a problem hiding this comment.
@amitk1sharma Thanks for your contribution! I don't have more comments. Please check the comments from @afdesk when you get a chance. Thanks!
8ee292d to
e031393
Compare
|
Hi @afdesk @mozillazg, I have resolved the previous comments. |
e031393 to
acf5330
Compare
|
Hi @afdesk @mozillazg, |
mozillazg
left a comment
mozillazg
left a comment
There was a problem hiding this comment.
LGTM, Thanks for your contribution!
f394f56 to
f5a3aba
Compare
|
@afdesk Rebase Done. |
@amitk1sharma thanks for your efforts. Could you pls take a look at them and update? I realize that some notes weren't made in your PR, but these typos should be fixed too to improve the project. |
c9b67f9 to
8cad908
Compare
|
Hi @afdesk @mozillazg @andypitcher , I’ve addressed all the previous review comments and updated the PR accordingly. Thank you! |
|
@amitk1sharma thank you so much for your efforts! |
8cad908 to
e911771
Compare
|
@amitk1sharma thanks for your efforts! |
e911771 to
606ad21
Compare
606ad21 to
ea304a3
Compare
|
Hi @afdesk @mozillazg @andypitcher, Just a gentle follow-up on this PR. Thanks! |
ea304a3 to
e60f892
Compare
|
Hi @afdesk @mozillazg @andypitcher , Just a gentle reminder regarding this PR. It has been open for a couple of weeks now. Thanks in advance! |
e60f892 to
56a455a
Compare
|
Hi @afdesk @mozillazg @andypitcher, Just following up on this PR once again. I have updated the branch with the latest changes from main and addressed everything from my side. Whenever you get a chance, could you please review and help merge it if everything looks good? Thank you! |
56a455a to
e348670
Compare
|
Hi @afdesk @mozillazg, Just following up on this PR once again. I have resolved the previous comments. Thank you! |
|
Hi @afdesk, |
LaibaBareera
left a comment
LaibaBareera
left a comment
There was a problem hiding this comment.
@amitk1sharma, i have some concerns related modifications in audit command in master.yaml file of rh-1.8
e348670 to
8a33827
Compare
|
Hi @afdesk, I’ve addressed all the previous review comments. Thank you! |
sync cfg updates sync cfg updates with upstream Resolve PR comments comments resolve PR comments resolved Removed extra space Correct spacing and indentation issues Resolved PR comments Resolve PR comments
8a33827 to
ef2cdf0
Compare
|
Hi @LaibaBareera, I’ve addressed all the previous review comments. Thank you! |
|
Hi @LaibaBareera , I’ve addressed all the previous review comments. Thank you! |
6 participants
This PR fixes several test case inconsistencies and incorrect audit commands in the benchmark YAML files for:
rh-1.8
cis-1.11
gke-1.8.0
eks-1.7.0
Changes made:
Fixed incorrect test case names and descriptions
Updated audit commands
Adjusted scored values to align with CIS standards
Improved remediation steps for clarity
Verified validation paths for OCP, GKE, and EKS consistency
Associated Issue: Fixes #1993