fix: dumper should write output to DumpName

[trim21]

Summary by CodeRabbit

• New Features

  • Database dumps for MySQL and PostgreSQL are now saved directly as compressed files, avoiding stdout. This simplifies export workflows and ensures outputs are stored reliably with the expected dump filename.

• Chores

  • Updated ignore settings to exclude IDE project files (.idea) from version control.

[coderabbitai]

Walkthrough

Redirected gzip command output from standard output to a created file named by DumpName in both MySQL and PostgreSQL dump implementations. Added file creation, error handling, and deferred close. Updated .gitignore to include .idea/. No changes to exported/public APIs.

Changes

Cohort / File(s)	Summary
DB dump gzip output to file pkg/dbdump/mysql/mysql.go, pkg/dbdump/postgres/postgres.go	Create output file using DumpName, set gzipCmd.Stdout to the file instead of os.Stdout, add error handling and deferred close; keep stderr to os.Stderr and existing command pipeline unchanged.
Git ignore update .gitignore	Added .idea/ to ignored paths.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Caller
  participant Dump as Dump.Exec
  participant DumpTool as [mysqldump/pg_dump]
  participant Gzip as gzip
  participant File as DumpName (.gz)

  Caller->>Dump: Exec()
  Dump->>DumpTool: start
  DumpTool-->>Gzip: dump stdout (pipe)
  Dump->>File: create DumpName
  Gzip-->>File: write compressed bytes (stdout redirected)
  DumpTool-->>Dump: exit
  Gzip-->>Dump: exit
  Dump-->>Caller: return
  note over Dump,Gzip: stderr remains directed to os.Stderr

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit taps keys with a gentle cheer,
“From streams to files, the bytes go here!”
Gzip now hums, a tidy tune,
DumpName cradles data soon.
.idea hops outside the repo line—
Carrots compiled, backups fine. 🥕📦

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title clearly and concisely summarizes the primary change of redirecting the dumper’s output to the DumpName file rather than stdout, matching the code modifications in both MySQL and Postgres dump implementations. It is specific to the core fix without extraneous details or generic phrasing. Its phrasing “fix: dumper should write output to DumpName” accurately reflects the developer’s intent and aligns with conventional commit syntax.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

pkg/dbdump/postgres/postgres.go (1)

80-87: File creation and output redirection look correct.

The implementation properly creates the output file, handles creation errors, and redirects gzip output to the file. The deferred close ensures cleanup even on early returns.

Consider checking the error from f.Close() to catch potential write failures:

-	defer f.Close()
+	defer func() {
+		if closeErr := f.Close(); closeErr != nil && err == nil {
+			err = fmt.Errorf("failed to close dump file: %w", closeErr)
+		}
+	}()

This would require naming the return value, but it's a minor improvement that can be deferred.

pkg/dbdump/mysql/mysql.go (1)

79-86: File creation and output redirection look correct.

The implementation properly creates the output file, handles creation errors, and redirects gzip output to the file. The deferred close ensures cleanup even on early returns.

Two minor observations:

1. This code is duplicated in pkg/dbdump/postgres/postgres.go (lines 80-87). Consider extracting the file creation and gzip stdout setup into a shared helper if more database types are added.

2. Consider checking the error from f.Close() to catch potential write failures:

-	defer f.Close()
+	defer func() {
+		if closeErr := f.Close(); closeErr != nil && err == nil {
+			err = fmt.Errorf("failed to close dump file: %w", closeErr)
+		}
+	}()

Both suggestions can be deferred to future work.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6ae849 and 7a0fb59.

📒 Files selected for processing (3)

• .gitignore (1 hunks)
• pkg/dbdump/mysql/mysql.go (1 hunks)
• pkg/dbdump/postgres/postgres.go (1 hunks)

🔇 Additional comments (1)

.gitignore (1)

21-21: LGTM!

Adding .idea/ to .gitignore is appropriate for excluding JetBrains IDE configuration files from version control.