Allow newer versions of PyTorch than we have verified.#39
Merged
Conversation
TobyRoseman
commented
Jul 14, 2026
TobyRoseman
commented
Contributor
- Remove max PyTorch version for installing coreai-torch.
- Pin PyTorch versions for testing.
- Warn user if they have newer version of PyTorch than we have verified.
TobyRoseman
requested review from
DawerG,
YifanShenSZ,
gokulkrishna98,
guru-desh and
jakesabathia2
July 14, 2026 17:37
gokulkrishna98
approved these changes
Jul 14, 2026
guru-desh
reviewed
Jul 14, 2026
| "pytest-xdist", | ||
| "torchaudio", | ||
| "torchvision", | ||
| "torch==2.13.0", |
There was a problem hiding this comment.
nit: if you plan to test on different torch versions, you could move the torch dependencies to a different dependency group and then "import" it into this group by doing { include-group = ... }
jakesabathia2
approved these changes
Jul 14, 2026
TobyRoseman
force-pushed
the
pytorch-future-versions
branch
from
July 15, 2026 00:12
09dc0c7 to
f1602dd
Compare
Contributor
Author
Thanks. Done. I didn't know about this. I've added setup instructions to the README as part of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.