Bug fix: max_pool2d default stride value#36
Merged
Conversation
gokulkrishna98
approved these changes
Jul 10, 2026
gokulkrishna98
left a comment
gokulkrishna98
left a comment
Contributor
There was a problem hiding this comment.
Nice catch, thanks.
TobyRoseman
force-pushed
the
max-pool-bug-fix
branch
2 times, most recently
from
July 13, 2026 16:55
1e81ec6 to
6e128d1
Compare
TobyRoseman
force-pushed
the
max-pool-bug-fix
branch
from
July 13, 2026 18:34
6e128d1 to
2124b24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We assume
strideis always set formax_pool2d. However, the default value isNone. This means thekernel_sizeshould be used.