Skip to content

[BANK-2106] Migrate gem source from RubyGems to JFrog #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maimer merged 1 commit into from
Jun 27, 2026
Merged

[BANK-2106] Migrate gem source from RubyGems to JFrog #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ version: 2.1

orbs:
gem-tool: appfolio/gem-tool@volatile
public-packages: https://raw.githubusercontent.com/appfolio/public-packages/v1/orbs/public-packages.yml

commands:
install_dependencies:
Expand Down Expand Up @@ -58,6 +59,7 @@ workflows:
- '3.4.8'
- '3.3.10'
after-checkout-steps:
- public-packages/setup
- install_dependencies
after-appraisal-install-steps:
- run:
Expand All @@ -77,6 +79,7 @@ workflows:
- '3.4.8'
- '3.3.10'
after-checkout-steps:
- public-packages/setup
- install_dependencies
after-appraisal-install-steps:
- run:
Expand All @@ -96,6 +99,7 @@ workflows:
- '3.4.8'
- '3.3.10'
after-checkout-steps:
- public-packages/setup
- install_dependencies
after-appraisal-install-steps:
- run:
Expand Down
5 changes: 5 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ registries:
type: rubygems-server
url: https://rubygems.pkg.github.com/appfolio
token: "${{secrets.READ_ONLY_PACKAGES_CCIMU}}"
public-rubygems-packages:
type: rubygems-server
url: https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/
jfrog-oidc-provider-name: appfolio-github-oidc
audience: jfrog-appfolio
updates:
- package-ecosystem: bundler
directory: "/"
Expand Down
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# frozen_string_literal: true

source 'https://rubygems.org' # global source
source 'https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/'

source 'https://rubygems.org' do
source 'https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/' do
gem 'appraisal', '>= 2.5', '< 3'
gem 'bundler', '>= 2.6', '< 5'
gem 'debug', '>= 1.11', '< 2'
Expand Down
11 changes: 4 additions & 7 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,10 @@ class SeleniumRunner
puts "Running '#{command}'"
return if @options[:dry]

specific_gemfile_env = Bundler.clean_env

if gemfile
specific_gemfile_env['BUNDLE_GEMFILE'] = gemfile
end

Bundler.send(:with_env, specific_gemfile_env) do
jfrog_creds = ENV['BUNDLE_APPFOLIO__JFROG__IO']
Bundler.with_unbundled_env do
ENV['BUNDLE_GEMFILE'] = gemfile if gemfile
ENV['BUNDLE_APPFOLIO__JFROG__IO'] = jfrog_creds if jfrog_creds
system(command)
raise unless $?.exitstatus == 0
end
Expand Down
2 changes: 1 addition & 1 deletion test/test_apps/7.2/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source 'https://rubygems.org'
source 'https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
Expand Down
4 changes: 2 additions & 2 deletions test/test_apps/7.2/engines/forum/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source "http://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

# Declare your gem's dependencies in forum.gemspec.
# Bundler will treat runtime dependencies like base dependencies, and
Expand All @@ -11,7 +11,7 @@ gem "jquery-rails"
# Declare any dependencies that are still in development here instead of in
# your gemspec. These might include edge Rails or gems from your path or
# Git. Remember to move these dependencies to your gemspec before releasing
# your gem to rubygems.org.
# your gem.

# To use debugger
# gem 'debugger'
2 changes: 1 addition & 1 deletion test/test_apps/7.2/gemfiles/ruby_3.3.10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

gem "minitest", "~> 5.0"
gem "rails", "~> 7.2.0"
Expand Down
2 changes: 1 addition & 1 deletion test/test_apps/7.2/gemfiles/ruby_3.4.8.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

gem "minitest", "~> 5.0"
gem "rails", "~> 7.2.0"
Expand Down
2 changes: 1 addition & 1 deletion test/test_apps/7.2/gemfiles/ruby_4.0.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

gem "minitest", "~> 5.0"
gem "rails", "~> 7.2.0"
Expand Down
2 changes: 1 addition & 1 deletion test/test_apps/8.0/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source 'https://rubygems.org'
source 'https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
Expand Down
4 changes: 2 additions & 2 deletions test/test_apps/8.0/engines/forum/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source "http://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

# Declare your gem's dependencies in forum.gemspec.
# Bundler will treat runtime dependencies like base dependencies, and
Expand All @@ -11,7 +11,7 @@ gem "jquery-rails"
# Declare any dependencies that are still in development here instead of in
# your gemspec. These might include edge Rails or gems from your path or
# Git. Remember to move these dependencies to your gemspec before releasing
# your gem to rubygems.org.
# your gem.

# To use debugger
# gem 'debugger'
2 changes: 1 addition & 1 deletion test/test_apps/8.0/gemfiles/ruby_3.3.10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

gem "minitest", "~> 5.0"
gem "rails", "~> 8.0.0"
Expand Down
2 changes: 1 addition & 1 deletion test/test_apps/8.0/gemfiles/ruby_3.4.8.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

gem "minitest", "~> 5.0"
gem "rails", "~> 8.0.0"
Expand Down
2 changes: 1 addition & 1 deletion test/test_apps/8.0/gemfiles/ruby_4.0.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

gem "minitest", "~> 5.0"
gem "rails", "~> 8.0.0"
Expand Down
2 changes: 1 addition & 1 deletion test/test_apps/8.1/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source 'https://rubygems.org'
source 'https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
Expand Down
4 changes: 2 additions & 2 deletions test/test_apps/8.1/engines/forum/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source "http://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

# Declare your gem's dependencies in forum.gemspec.
# Bundler will treat runtime dependencies like base dependencies, and
Expand All @@ -11,7 +11,7 @@ gem "jquery-rails"
# Declare any dependencies that are still in development here instead of in
# your gemspec. These might include edge Rails or gems from your path or
# Git. Remember to move these dependencies to your gemspec before releasing
# your gem to rubygems.org.
# your gem.

# To use debugger
# gem 'debugger'
2 changes: 1 addition & 1 deletion test/test_apps/8.1/gemfiles/ruby_3.3.10.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

gem "rails", "~> 8.1.0"
gem "sqlite3", "~> 2.1"
Expand Down
2 changes: 1 addition & 1 deletion test/test_apps/8.1/gemfiles/ruby_3.4.8.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

gem "rails", "~> 8.1.0"
gem "sqlite3", "~> 2.1"
Expand Down
2 changes: 1 addition & 1 deletion test/test_apps/8.1/gemfiles/ruby_4.0.1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This file was generated by Appraisal

source "https://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

gem "rails", "~> 8.1.0"
gem "sqlite3", "~> 2.1"
Expand Down
4 changes: 2 additions & 2 deletions test/test_apps/shared/engines/forum/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
source "http://rubygems.org"
source "https://appfolio.jfrog.io/artifactory/api/gems/appfolio-ae_page_objects-gem/"

# Declare your gem's dependencies in forum.gemspec.
# Bundler will treat runtime dependencies like base dependencies, and
Expand All @@ -11,7 +11,7 @@ gem "jquery-rails"
# Declare any dependencies that are still in development here instead of in
# your gemspec. These might include edge Rails or gems from your path or
# Git. Remember to move these dependencies to your gemspec before releasing
# your gem to rubygems.org.
# your gem.

# To use debugger
# gem 'debugger'
Loading