ADFA-4841: Fix trivial build warnings#1572
Merged
davidschachterADFA merged 4 commits intoJul 24, 2026
Merged
Conversation
android:icon, android:name, and android:allowBackup had nothing to actually replace (no other manifest declares them), producing 3 manifest-merger warnings per build. supportsRtl/theme are genuinely overridden elsewhere, so those stay. Co-Authored-By: Claude Sonnet 5 <[email protected]>
git_clone, git_clone_failed, git_clone_in_progress, git_clone_repo_url, git_clone_repo, git_clone_success, and idepref_github_summary existed in 11 locale files with no default (English) value and zero code references anywhere - dead translations for a removed/never-shipped feature. AAPT2 already silently drops them at build time for lacking a default value; this just removes the dead source and the 14 resulting "removing resource ... without required default value" warnings. Co-Authored-By: Claude Sonnet 5 <[email protected]>
JNINativeMethod's name/signature fields are typed char* (not const char*) in the NDK's legacy JNI headers, so initializing them directly with string literals triggers -Wwritable-strings under C++11. Cast each literal explicitly, matching the field type - eliminates all 12 warnings (6 entries x 2 fields) with no behavior change. Co-Authored-By: Claude Sonnet 5 <[email protected]>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
💤 Files with no reviewable changes (11)
📝 Walkthrough
WalkthroughThe pull request narrows manifest merge replacements, updates localized IDE and Git strings across eleven locales, and adds explicit casts to PairingContext JNI method names without changing their bindings. ChangesManifest merge configuration
Localized resource cleanup
JNI registration compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hal-eisen-adfa
approved these changes
Jul 24, 2026
jatezzz
approved these changes
Jul 24, 2026
Collaborator
Author
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on the build log for run 30053583432 / job 89360621449, which had 4,409 warning lines. Three genuinely trivial fixes:
tools:replaceinAndroidManifest.xmlto onlysupportsRtl,theme-icon/name/allowBackuphad nothing to replace (no other manifest declares them), producing 3 manifest-merger warnings with zero effect on the merged output.git_clone*,idepref_github_summary) across 11 locale files - no default value, zero code references anywhere, dead weight from a removed/never-shipped feature. AAPT2 already silently drops them for lacking a default; this removes the dead source and 14 "removing resource ... without required default value" warnings.-Wwritable-stringswarnings inadb_pairing.cpp-JNINativeMethod's legacy NDK struct fields are typedchar*, so literal string init needs an explicit cast.Not attempted here (flagged as bigger, separate work):
Test plan
:app:assembleV8Debugbuilds successfully-Wwritable-stringswarnings