Skip to content

ADFA-4551: Remove unused bundled dependency files#1569

Merged
davidschachterADFA merged 4 commits into
stagefrom
fix/ADFA-4551-remove-unused-bundled-files
Jul 24, 2026
Merged

ADFA-4551: Remove unused bundled dependency files#1569
davidschachterADFA merged 4 commits into
stagefrom
fix/ADFA-4551-remove-unused-bundled-files

Conversation

@davidschachterADFA

Copy link
Copy Markdown
Collaborator

Summary

  • Excludes non-class resource files from three third-party jars that are never referenced by app code: commons-codec's Beider-Morse phonetic rule data, JLine console resources bundled in the Kotlin analysis-api jar, an IntelliJ K2-mode compatibility manifest, and unused bundled .proto well-known-type sources.
  • Removes the unused com.google.genai dependency entirely (also drops one of three paths pulling commons-codec's phonetic data into the APK).

Investigated but intentionally left untouched:

  • openjdk/tools/ - our own vendored javac, heavily used by the Java LSP.
  • play-services-* - real transitive dependency of Firebase Analytics, which is actively used.

Part of ADFA-4551 (APK size reduction), split into separate PRs per sub-concern.

Test plan

  • :app:assembleV8Debug builds successfully with these excludes/removal applied
  • Confirm release build packaging picks up the same excludes

davidschachterADFA and others added 2 commits July 23, 2026 14:45
Removes non-class resource files from three third-party jars that are
never referenced by app code: commons-codec's Beider-Morse phonetic
rule data, JLine console resources bundled in the Kotlin analysis-api
jar, an IntelliJ K2-mode compatibility manifest, and unused bundled
.proto well-known-type sources.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Nothing in the app calls into google-genai - it's dead weight on this
branch (belongs to an in-progress, unmerged agent feature elsewhere).
Also drops one of the three paths pulling commons-codec's phonetic
data into the APK.

Co-Authored-By: Claude Sonnet 5 <[email protected]>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4735ad94-04e1-4b9a-bff2-2cda97fa6b56

📥 Commits

Reviewing files that changed from the base of the PR and between ebd8bd7 and cac5d3d.

📒 Files selected for processing (1)
  • app/build.gradle.kts
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/build.gradle.kts

📝 Walkthrough
  • Reduced APK/AAB size by excluding unused bundled resources from third-party JARs (Beider-Morse phonetic rule data, JLine console resources, IntelliJ K2-mode compatibility manifest) and bundled protobuf well-known-type sources.
  • Removed the unused com.google.genai dependency (including its version-catalog entries).
  • Added Android lifecycle process and runtime KTX dependencies.
  • Confirmed :app:assembleV8Debug builds successfully.
  • Risk: Release packaging has not yet been verified; excluded resources should be validated across all build variants and checked with runtime/smoke tests to ensure nothing relied on the removed assets.

Walkthrough

The Android build excludes additional bundled resources, replaces the Google GenAI dependency with AndroidX lifecycle components, and removes the corresponding version catalog entries.

Changes

Android build updates

Layer / File(s) Summary
Resource packaging exclusions
app/build.gradle.kts
Adds exclusions for Beider-Morse data, JLine resources, the IntelliJ K2 manifest, and protobuf sources.
Lifecycle dependency wiring
gradle/libs.versions.toml, app/build.gradle.kts
Removes the Google GenAI catalog entries and adds AndroidX lifecycle process and runtime KTX dependencies.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A rabbit trims resources bright,
And guides lifecycle through the night.
GenAI hops from the catalog’s page,
While clean builds bound beyond the cage.
Soft paws check each changed line—
Hop, hop, the APKs shine!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change: removing unused bundled dependency files.
Description check ✅ Passed The description is directly related to the changes and test plan in this pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ADFA-4551-remove-unused-bundled-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@davidschachterADFA

Copy link
Copy Markdown
Collaborator Author

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, comment @claude review on this pull request to trigger a review.

@hal-eisen-adfa

Copy link
Copy Markdown
Collaborator

@claude review

Please do these code reviews inside your Claude Code using the /code-review skill - not here in Github, thanks

@hal-eisen-adfa hal-eisen-adfa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, the AI plugins that John is working on with add the google-genai back in though another path. Code On The Go size reduction will still be a benefit for folks who don't install those plugins.

@davidschachterADFA
davidschachterADFA merged commit 870ed53 into stage Jul 24, 2026
4 checks passed
@davidschachterADFA
davidschachterADFA deleted the fix/ADFA-4551-remove-unused-bundled-files branch July 24, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants