[RN 0.81] Do not set the ShadowNodeTraits::Trait::DirtyYogaNode - #646
Merged
Conversation
Contributor
Author
Collaborator
|
Thanks @cortinico ! Yes I am pretty sure this was a copy paste from core as it was my starting point for fabric implementation. |
janicduplessis
requested changes
Jul 10, 2025
janicduplessis
left a comment
janicduplessis
left a comment
Collaborator
There was a problem hiding this comment.
Looks like this is the commit that removes it from core react/react-native@ecf1b84. Let's also remove the method completely.
Contributor
Author
done |
janicduplessis
approved these changes
Jul 10, 2025
Collaborator
|
Released in 5.5.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not sure why you folks are setting the
ShadowNodeTraits::Trait::DirtyYogaNodetrait on the SafeAreaView Shadow Node (is it a copy form the core one?).This trait is going away in core in 0.81.
I'm actually re-adding it to reduce the blast radius of this breaking change, but still it would be worth to clean this up.
Fixes #645