Add support for all standard escape codes in /etc/issue#175
Open
dr-carlos wants to merge 3 commits into
Open
Conversation
|
@apognu Up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to add support for all escape codes (except \O: see below) in the agetty manual, usable in the /etc/issue file, in response to Arch Linux changing their default /etc/issue to require more fully-fledged support. This PR fixes #169.
I wasn't sure whether (or how) to add any tests, but tested locally with the following /etc/issue:
\e{halfbright}\e{yellow}\d \4 \4{lo} \6 \b \s \S \e[0m\S{BUILD_ID} \S{ANSI_COLOR}(\S{PRETTY_NAME}) \l \m \n \o \r \t \u \U \vThis lined up with the output from agetty.
I could not figure out how to find \O (DNS hostname: as reported by
hostname -d) in Rust, so if you have any advice on this, please let me know.Please also let me know if you'd like me to add or change anything, especially as I've never programmed in Rust before nor contributed to this project.