Skip to content

chore: Don't test bindings on Node.js 20 + Intel + macOS combination#449

Merged
fnesveda merged 1 commit into
masterfrom
fix/skip-broken-node-version
May 18, 2026
Merged

chore: Don't test bindings on Node.js 20 + Intel + macOS combination#449
fnesveda merged 1 commit into
masterfrom
fix/skip-broken-node-version

Conversation

@fnesveda
Copy link
Copy Markdown
Member

Due to an upstream Node.js bug, which will not be fixed on Node 20 as it is EOL, PNPM does not ship a working binary for Intel macOS (see pnpm/pnpm#11423 and nodejs/node#62893), and the setup-pnpm step cannot run.

We've decided to just skip this combination in CI, as we believe the bindings should be sufficiently tested by all the other combinations.

@fnesveda fnesveda added the adhoc Ad-hoc unplanned task added during the sprint. label May 18, 2026
@fnesveda fnesveda requested a review from barjin May 18, 2026 10:04
@github-actions github-actions Bot added the t-management Issues with this label belong to the CTO or engineering managers. label May 18, 2026
Copy link
Copy Markdown
Member

@barjin barjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@barjin
Copy link
Copy Markdown
Member

barjin commented May 18, 2026

(please make the PR title a chore: so this doesn't end up in the changelog @fnesveda )

@fnesveda fnesveda changed the title fix: Don't test bindings on Node.js 20 + Intel + macOS combination chore: Don't test bindings on Node.js 20 + Intel + macOS combination May 18, 2026
@fnesveda fnesveda merged commit 91e2e20 into master May 18, 2026
33 checks passed
@fnesveda fnesveda deleted the fix/skip-broken-node-version branch May 18, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-management Issues with this label belong to the CTO or engineering managers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants