test: cover ShareAccessComponent behaviors in spec#5233
Open
Ma77Ball wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
/request-review @aglinxinyuan |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the unit test coverage for ShareAccessComponent in the dashboard “share access” modal, moving from minimal routing assertions to behavior-focused tests that exercise the component’s access management and publish/unpublish flows.
Changes:
- Adds comprehensive specs for
ngOnInit, email tag parsing (handleInputConfirm,onPaste), and access grant behaviors (grantAccess,hasWriteAccess). - Adds modal-driven confirmation flow tests for revoke, access level changes, and publish/unpublish actions by capturing
NzModalService.createconfigs and invoking footer callbacks. - Refactors the spec setup helper to parameterize modal data and current user email, and resets the TestBed per test to avoid provider state bleed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aglinxinyuan
approved these changes
May 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5233 +/- ##
============================================
+ Coverage 48.72% 48.78% +0.05%
- Complexity 2375 2379 +4
============================================
Files 1044 1042 -2
Lines 40096 39971 -125
Branches 4252 4252
============================================
- Hits 19538 19500 -38
+ Misses 19411 19318 -93
- Partials 1147 1153 +6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
share-access.component.spec.tsfrom 4 routing-only tests to 44 tests grouped by behavior:ngOnInit,handleInputConfirm,onPaste,grantAccess,hasWriteAccess,verifyRevokeAccess/revokeAccess,changeAccessLevel,verifyPublish/verifyUnpublish, and the individual publish/unpublish methods.NzModalService.createand invoking the relevantnzFooterbutton'sonClick, so each test asserts against the specific Confirm/Cancel path it cares about.setupComponenthelper withtype,id,inWorkspace, andcurrentEmailoverrides, and reset the TestBed inbeforeEachso each test reconfigures providers (e.g., a WRITE access entry forhasWriteAccess, an already-published item forverifyPublish) without bleed-over.Any related issues, documentation, or discussions?
Closes: #5223
How was this PR tested?
yarn format:fix(touched the new spec only).yarn test --include="src/app/dashboard/component/user/share-access/share-access.component.spec.ts": 44/44 passing.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF