[SEDONA-755] fix: remove redundant bounds check from rasterization scanline logic#2960
Open
prantogg wants to merge 1 commit into
Open
[SEDONA-755] fix: remove redundant bounds check from rasterization scanline logic#2960prantogg wants to merge 1 commit into
prantogg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
Removed a redundant
xIntercept < 0 || xIntercept > rasterWidthcheck in the vertical line case ofRasterization.computeScanlineIntersections(). This check was incorrectly skipping valid scanlines for polygons whose edges align with the raster boundary. After clipping to raster extent, floating-point arithmetic can produce xIntercept values like256.0000000000005(exceeding raster width by ~5e-13), causing the check to skip valid scanline intersections and produce incorrect rasterization results.The non-vertical (else) branch already uses geometry-extent-based bounds (
xMin/xMax) which correctly handles this case. The vertical line branch doesn't need bounds checking at all since the polygon has already been clipped to the raster extent.How was this patch tested?
testZonalStatsEdgeCase) that reproduces the issue with a polygon threading along the raster edgeDid this PR include necessary documentation updates?