feat(pouchdb-mapreduce): (#9104) - enable _stats reducer to digest arrays of numbers - #9108
Merged
Conversation
SourceR85
changed the title
SourceR85
requested changes
Aug 5, 2025
SourceR85
reviewed
Aug 5, 2025
Contributor
|
Well, that doesn't run either...
Don't worry, sometimes even I forget to run the linter ;) |
The builtin _sum reducer properly handles numbers AND arrays of numbers, returning an array of sums. In couchdb, this is also true for the _stats reducer, which returns an array of stats objects.
Contributor
Author
|
bare with me, I will get it ;-) |
SourceR85
approved these changes
Aug 6, 2025
SourceR85
left a comment
SourceR85
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you for your contribution 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builtin _sum reducer properly handles numbers AND arrays of numbers, returning an array of sums.
In couchdb, this is also true for the _stats reducer, which returns an array of stats objects.