OPENNLP-1850: Offset/alignment layer — Alignment, AlignedText, buildAligned (1b/5)#1109
Draft
krickert wants to merge 1 commit into
Draft
OPENNLP-1850: Offset/alignment layer — Alignment, AlignedText, buildAligned (1b/5)#1109krickert wants to merge 1 commit into
krickert wants to merge 1 commit into
Conversation
This was referenced Jun 23, 2026
Closed
krickert
force-pushed
the
OPENNLP-1850-1b-alignment
branch
from
08de0d3 to
9af6d92
Compare
…gned, *Aligned (1b) The conceptually hard half of the former foundation PR, split out on review request: the bidirectional Alignment edit-sequence and AlignedText, the OffsetAwareNormalizer capability interface, TextNormalizer.buildAligned(), the *Aligned CharClass variants and the offset-aware rungs, the line-break-preserving rung, and the dense span-mapping tests (binary-search span mapping, expansion/deletion edge cases, andThen composition including the insertion-in-expansion case). Builds on the engine in 1a.
krickert
force-pushed
the
OPENNLP-1850-1b-alignment
branch
from
9af6d92 to
9dc7d51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1b of the OPENNLP-1850 stack: the offset/alignment layer, split out of the former foundation PR (#1103) on review request so the conceptually hard part gets a focused read on its own. Builds on the engine in #1108.
Adds:
Alignment(bidirectional edit-sequence,andThen-composable) andAlignedTextOffsetAwareNormalizercapability interface andTextNormalizer.buildAligned()*AlignedCharClassvariants, the offset-aware rungs, and the line-break-preserving rungandThencomposition including the insertion-inside-an-expansion caseBase:
OPENNLP-1850-1a-engine(#1108). Stack: 1a → 1b (this) → tokenizer → DL → docs.