JGIT SSH commit signing / NetBinox removal / JNA as OSGI bundle

.github/workflows/main.yml

@@ -1117,19 +1117,6 @@ jobs:
       - name: platform/openide.util.ui
         run: ant $OPTS -f platform/openide.util.ui test
 
-      # isolation required by netbinox tests
-      - name: isolate platform build
-        run: |
-          cp -r platform/ _platform/ && cp -r harness/ _harness/ && cp nbbuild/build/nbantext.jar .
-          cp -r nbbuild/netbeans/platform/ _nb_platform/ && cp -r nbbuild/netbeans/harness/ _nb_harness/
-          ant $OPTS -quiet clean && rm -Rf platform/ && rm -Rf harness/
-          mkdir nbbuild/build && mkdir nbbuild/netbeans
-          mv _platform/ platform/ && mv _harness/ harness/ && mv nbantext.jar nbbuild/build/
-          mv _nb_platform/ nbbuild/netbeans/platform/ && mv _nb_harness/ nbbuild/netbeans/harness/
-
-      - name: platform/netbinox
-        run: ant $OPTS -f platform/netbinox test -Dtest.config=stableBTD
-
       - name: Create Test Summary
         uses: test-summary/action@37b508cfee6d4d080eedd00b5bb240a6a784a6a5 # v2.6
         if: failure()

ide/git/nbproject/project.xml

@@ -30,6 +30,22 @@
                     <compile-dependency/>
                     <run-dependency/>
                 </dependency>
+                <dependency>
+                    <code-name-base>org.eclipse.jgit.gpg.bc</code-name-base>
+                    <run-dependency/>
+                </dependency>
+                <dependency>
+                    <code-name-base>org.eclipse.jgit.lfs</code-name-base>
+                    <run-dependency/>
+                </dependency>
+                <dependency>
+                    <code-name-base>org.eclipse.jgit.ssh.apache</code-name-base>
+                    <run-dependency/>
+                </dependency>
+                <dependency>
+                    <code-name-base>org.eclipse.jgit.ssh.apache.agent</code-name-base>
+                    <run-dependency/>
+                </dependency>
                 <dependency>
                     <code-name-base>org.netbeans.api.annotations.common</code-name-base>
                     <build-prerequisite/>

ide/git/src/org/netbeans/modules/git/client/CredentialsCallback.java

@@ -78,6 +78,15 @@ public char[] getPassword (String uri, String prompt) {
             pwd = password.clone();
             Arrays.fill(password, (char) 0);
             credentialsReady = false;
+        } else if (passphrase != null) {
+            // the jgit apache mina client uses password instead of passphrase
+            // to unlock the identity file, an additional guard could be to
+            // check for prompt "Passphrase", but that is/could be a localized.
+            // As only ever either password _or_ passphrase are available, this
+            // should be save (see fetchCredentials)
+            pwd = passphrase.clone();
+            Arrays.fill(passphrase, (char) 0);
+            credentialsReady = false;
         }
         return pwd;
     }

ide/ide.kit/manifest.mf

@@ -2,5 +2,4 @@ Manifest-Version: 1.0
 OpenIDE-Module: org.netbeans.modules.ide.kit
 OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/ide/kit/Bundle.properties
 OpenIDE-Module-Specification-Version: 1.66
-OpenIDE-Module-Needs: org.netbeans.Netbinox
 

ide/libs.git/manifest.mf

@@ -2,3 +2,4 @@ Manifest-Version: 1.0
 OpenIDE-Module: org.netbeans.libs.git/1
 OpenIDE-Module-Localizing-Bundle: org/netbeans/libs/git/Bundle.properties
 OpenIDE-Module-Specification-Version: 1.68
+OpenIDE-Module-Install: org/netbeans/libs/git/jgit/Installer.class

ide/libs.git/nbproject/project.xml

@@ -26,11 +26,11 @@
             <code-name-base>org.netbeans.libs.git</code-name-base>
             <module-dependencies>
                 <dependency>
-                    <code-name-base>com.jcraft.jsch</code-name-base>
+                    <code-name-base>org.apache.sshd.osgi</code-name-base>
                     <build-prerequisite/>
                     <compile-dependency/>
                     <run-dependency>
-                        <specification-version>0.1.55</specification-version>
+                        <specification-version>2.17.1</specification-version>
                     </run-dependency>
                 </dependency>
                 <dependency>
@@ -42,20 +42,27 @@
                     </run-dependency>
                 </dependency>
                 <dependency>
-                    <code-name-base>org.eclipse.jgit.ssh.jsch</code-name-base>
+                    <code-name-base>org.eclipse.jgit.ssh.apache</code-name-base>
                     <build-prerequisite/>
                     <compile-dependency/>
                     <run-dependency>
-                        <specification-version>6.7</specification-version>
+                        <specification-version>7.6.0</specification-version>
+                    </run-dependency>
+                </dependency>
+                <dependency>
+                    <code-name-base>org.openide.modules</code-name-base>
+                    <build-prerequisite/>
+                    <compile-dependency/>
+                    <run-dependency>
+                        <specification-version>7.81</specification-version>
                     </run-dependency>
                 </dependency>
                 <dependency>
-                    <code-name-base>org.netbeans.libs.jsch.agentproxy</code-name-base>
+                    <code-name-base>org.openide.util.ui</code-name-base>
                     <build-prerequisite/>
                     <compile-dependency/>
                     <run-dependency>
-                        <release-version>2</release-version>
-                        <specification-version>1.0</specification-version>
+                        <specification-version>9.42</specification-version>
                     </run-dependency>
                 </dependency>
             </module-dependencies>

ide/libs.git/src/org/netbeans/libs/git/jgit/Installer.java

@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.libs.git.jgit;
+
+import java.util.stream.Collectors;
+import org.apache.sshd.common.util.security.SecurityUtils;
+import org.openide.modules.ModuleInstall;
+
+import static org.apache.sshd.common.util.security.SecurityUtils.DEFAULT_SECURITY_PROVIDER_REGISTRARS;
+
+public class Installer extends ModuleInstall {
+
+    @Override
+    public void restored() {
+        // Override the security providers Apache Mina. EdDSASecurityProviderRegistrar
+        // uses net.i2p.crypto.eddsa to provide support for ed25519, that is not
+        // needed, as BouncyCastle also has support for the curve. As long as the
+        // security provider is activated Mina will try to load it and fail fatally
+        // if that fails.
+        System.setProperty(
+                SecurityUtils.SECURITY_PROVIDER_REGISTRARS,
+                DEFAULT_SECURITY_PROVIDER_REGISTRARS
+                        .stream()
+                        .filter(e -> ! e.endsWith("EdDSASecurityProviderRegistrar"))
+                        .collect(Collectors.joining(","))
+        );
+        super.restored();
+    }
+
+}