[LIVY-1040] Migrate logging framework from Reload4j to Log4j2#525
Merged
Conversation
roczei
force-pushed
the
LIVY-1040
branch
9 times, most recently
from
b82c5bc to
31b4804
Compare
roczei
changed the title
Contributor
Author
|
Hi @ArnavBalyan, @peter-toth and @gyogal, This PR is ready for code review. Could you please take a look at this when you have a moment? Any feedback you provide would be greatly appreciated! Thank you! |
roczei
force-pushed
the
LIVY-1040
branch
4 times, most recently
from
17cef03 to
0f69454
Compare
Replaced the reload4j dependency with the Log4j2 library across all modules. Co-authored by Peter Toth and Gyorgy Gal: - Added log4j-api, log4j-core, log4j-slf4j-impl and log4j-1.2-api (backward-compat bridge) to dependencies - Removed ch.qos.reload4j:reload4j from all module poms - Migrated all log4j.properties test config files to log4j2.properties using the new Log4j2 property-file syntax (rootLogger, appender.* keys) Co-authored-by: Peter Toth <[email protected]> Co-authored-by: Gyorgy Gal <[email protected]>
Contributor
|
Thank you for updating the PR @roczei ! I ran some tests with the updated I also checked with the Maven dependency plugin that reload4j had been completely removed from the dependencies, so the change looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaced the reload4j dependency with the Log4j2 library across all modules.
Co-authored by Peter Toth and Gyorgy Gal:
How was this patch tested?
It has been manually tested with the existing unit tests.
Was this patch authored or co-authored using generative AI tooling?
No