optimize: optimize client reconnect scheduling - #8199
Open
Anon2Tokyo wants to merge 2 commits into
Open
Conversation
funky-eyes
added
first-time contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Moves client reconnect scheduling to a shared, role-based executor and adds lifecycle coverage.
Changes:
- Adds shared reconnect task registration and cancellation.
- Adds a test for same-role task sharing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
AbstractNettyRemotingClient.java |
Implements shared reconnect scheduling. |
NettyRemotingClientBehaviorTest.java |
Tests role-based task ownership. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+97
to
+98
| private static final ScheduledThreadPoolExecutor RECONNECT_EXECUTOR = | ||
| new ScheduledThreadPoolExecutor(1, new NamedThreadFactory("NettyClientReconnectTimer", true)); |
Comment on lines
+152
to
+154
| ReconnectTaskHolder taskHolder = RECONNECT_TASKS.get(transactionRole); | ||
| if (taskHolder != null && !taskHolder.future.isCancelled() && !taskHolder.future.isDone()) { | ||
| return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Optimize the RM/TM client reconnect scheduling in
AbstractNettyRemotingClient.The reconnect timer is now backed by a shared scheduled executor, and reconnect tasks are registered by transaction role. This avoids repeatedly scheduling reconnect tasks when clients with the same role are initialized.
A behavior test was added to verify that reconnect tasks are shared by transaction role and are only cancelled by the owner client.
Ⅱ. Does this pull request fix one issue?
fixes #5338
Ⅲ. Why don't you add test cases (unit test/integration test)?
Added unit coverage in
NettyRemotingClientBehaviorTest.Ⅳ. Describe how to verify it
mvn -pl core -am -Dtest=NettyRemotingClientBehaviorTest -DfailIfNoTests=false testⅤ. Special notes for reviews
This change only shares the reconnect scheduler. The existing
timerExecutorremains unchanged because it is also used by other timeout and cleanup tasks.