You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To align with the build methods in the tcp/websocket builders, add validation for server_address and api_url in QuicClientConfigBuilder::build() and HttpClientConfigBuilder::build(), respectively.
What changed?
In QuicClientConfigBuilder::build(), server_address is validated using validate_server_address.
In HttpClientConfigBuilder::build(), validation is performed in three steps:
Ensure the api_url can be successfully parsed by Url crate
If a scheme is present, restrict it to http or https
Ensure the parsed api_url contains only the host and port components in its URI
Local Execution
Passed / not passed
Passed
Pre-commit hooks ran / not ran
Ran
AI Usage
Standing-Man
changed the title
feat(config): add address validation for QUIC/HTTP builders
feat(configs): add address validation for QUIC/HTTP builders
Apr 22, 2026
❌ Patch coverage is 97.38562% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.16%. Comparing base (1e44cc5) to head (307a21e).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3075.
Rationale
To align with the build methods in the
tcp/websocketbuilders, add validation forserver_addressandapi_urlinQuicClientConfigBuilder::build()andHttpClientConfigBuilder::build(), respectively.What changed?
In
QuicClientConfigBuilder::build(),server_addressis validated usingvalidate_server_address.In
HttpClientConfigBuilder::build(), validation is performed in three steps:api_urlcan be successfully parsed byUrlcratehttporhttpsapi_urlcontains only thehostandportcomponents in its URILocal Execution
Passed
Ran
AI Usage