REST: Add pagination support for list_tables#3348
Open
ebyhr wants to merge 1 commit into
Open
Conversation
ebyhr
force-pushed
the
ebi/rest-page-tables
branch
2 times, most recently
from
78f1a49 to
0836699
Compare
ebyhr
force-pushed
the
ebi/rest-page-tables
branch
from
0836699 to
dc44cfc
Compare
Member
Author
|
@Fokko @geruh @rambleraptor Could you review this PR when you have time? It's similar to list_views PR #3349 |
rambleraptor
approved these changes
May 18, 2026
Contributor
rambleraptor
left a comment
rambleraptor
left a comment
There was a problem hiding this comment.
Looks just like View. Thanks for doing this!
| def test_list_tables_paginated_200(rest_mock: Mocker) -> None: | ||
| namespace = "examples" | ||
| # First page with next-page-token | ||
| rest_mock.get( |
Contributor
There was a problem hiding this comment.
small nit: consider some kind of helper function that attaches a new page to the rest_mock
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follows REST catalog spec:
Are these changes tested?
Yes, includes unit tests for paginated cases.
Are there any user-facing changes?