GUACAMOLE-2120: Support VT100 escape codes sent for function keys and keypad. - #1101
Merged
Merged
Conversation
eugen-keeper
marked this pull request as draft
August 14, 2025 13:55
eugen-keeper
force-pushed
the
vt100-function-keys
branch
3 times, most recently
from
September 15, 2025 17:44
10f3ab8 to
f8fc367
Compare
eugen-keeper
changed the title
eugen-keeper
marked this pull request as ready for review
September 15, 2025 19:01
eugen-keeper
marked this pull request as draft
September 15, 2025 20:02
eugen-keeper
marked this pull request as ready for review
September 15, 2025 20:16
eugen-keeper
force-pushed
the
vt100-function-keys
branch
from
September 24, 2025 15:43
f8fc367 to
8e21063
Compare
eugen-keeper
marked this pull request as draft
September 24, 2025 16:32
eugen-keeper
marked this pull request as ready for review
September 24, 2025 18:44
mike-jumper
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See details here: https://issues.apache.org/jira/browse/GUACAMOLE-2120
There are not exact names for the different keypad behaviors. You can assume that the default one is ANSI but VT100 is actually also ANSI. Also, it is not clear why Putty called the VT100 keypad behavior "VT100+". This can be because the original VT100 keyboard had only 4 function keys but new keyboards have more function keys. So for now I would use the following option names:
ESC[n~(sane as in Putty)VT100(same as we have right now for the terminal type)