FELIX-6829 Remove http.jetty dependency on commons-fileupload#505
Open
enapps-enorman wants to merge 3 commits into
Open
FELIX-6829 Remove http.jetty dependency on commons-fileupload#505enapps-enorman wants to merge 3 commits into
enapps-enorman wants to merge 3 commits into
Conversation
Contributor
Author
|
I believe the now unused ServletHandler#getMultipartSecurityContext and related code could also be removed since the only usage was in the now removed multipart handling code. But I thought I would get some feedback on the general approach before doing that extra cleanup. UPDATE: cleaned up the the dead code at 3627401 |
Contributor
|
@enapps-enorman I like the approach, it's just another dependency we can do without nowadays. I'm fine with removing and delegation to Jetty instead. |
Contributor
|
I suggest to run the OSGi TCK for the http service, http whiteboard and servlet whiteboard on the proposed change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jetty does not need the Apache commons-fileupload library. Modern versions of Jetty support the Java Servlet Specification (3.0 and newer), which includes built-in, native APIs to parse multipart/form-data requests.
Refactoring to use the standard servlet apis: