Skip to content

Reject non-ASCII hex digits in isValidInet6Address #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 1 commit into from
Jun 20, 2026
+11 −3
Merged

Reject non-ASCII hex digits in isValidInet6Address #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,14 @@ public boolean isValidInet6Address(String inet6Address) {
if (octet.length() > IPV6_MAX_HEX_DIGITS_PER_GROUP) {
return false;
}
final char char0 = octet.charAt(0);
if (char0 == '+' || char0 == '-') {
return false; // Integer.parseInt accepts a leading sign, which is not a valid hex group
// Only ASCII hex digits are valid. Integer.parseInt(_, 16) also tolerates a leading sign
// and the non-ASCII Unicode digits that Character.digit maps to 0-15 (for example the
// fullwidth and Arabic-Indic forms), none of which belong in an IPv6 hex group.
for (int n = 0; n < octet.length(); n++) {
final char ch = octet.charAt(n);
if ((ch < '0' || ch > '9') && (ch < 'A' || ch > 'F') && (ch < 'a' || ch > 'f')) {
return false;
}
}
int octetInt = 0;
try {
Expand Down
3 changes: 3 additions & 0 deletions src/test/java/org/apache/commons/validator/routines/InetAddressValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@ void testIPv6() {
assertFalse(validator.isValidInet6Address("1:2:3:4:5:6:7:+8"), "IPV6 1:2:3:4:5:6:7:+8 should be invalid"); // signed hex group
assertFalse(validator.isValidInet6Address("fe80::+1"), "IPV6 fe80::+1 should be invalid"); // signed hex group
assertFalse(validator.isValidInet6Address("::+f"), "IPV6 ::+f should be invalid"); // signed hex group
assertFalse(validator.isValidInet6Address("１２３４::"), "IPV6 with fullwidth digits should be invalid"); // non-ASCII hex group
assertFalse(validator.isValidInet6Address("١٢::"), "IPV6 with Arabic-Indic digits should be invalid"); // non-ASCII hex group
assertFalse(validator.isValidInet6Address("1:2:3:4:5:6:7:８"), "IPV6 with a fullwidth digit group should be invalid"); // non-ASCII hex group
assertTrue(validator.isValidInet6Address("1:2:3:4::7:8"), "IPV6 1:2:3:4::7:8 should be valid");
assertTrue(validator.isValidInet6Address("1:2:3::7:8"), "IPV6 1:2:3::7:8 should be valid");
assertTrue(validator.isValidInet6Address("1:2::7:8"), "IPV6 1:2::7:8 should be valid");
Expand Down
Loading