Bump org.junit:junit-bom from 5.14.3 to 6.1.1#714
Conversation
Bumps [org.junit:junit-bom](https://github.com/junit-team/junit-framework) from 5.14.3 to 6.1.1. - [Release notes](https://github.com/junit-team/junit-framework/releases) - [Commits](junit-team/junit-framework@r5.14.3...r6.1.1) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-version: 6.1.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
Bot
added
dependencies
|
@raboof |
|
can't downstream components either update to 6 or override the version to stick with 5 when they update? |
|
Almost all are on Java 8, so they all would have to override. |
|
junit is a build-time dependency, and while almost all commons components still target Java 8, they're typically built on newer JVM's, aren't they? |
|
Hi @raboof |
I'm aware of that Buffer issue, and indeed building on Java8 is a workaround for it. However, looking at the last few votes (both by you and Mark), AFAICT in practice we're often not building releases with Java 8 at all. This is OK because the parent pom already has the java-9-up profile setting |
|
It's not for us that this matters, but for downstream users like some Linux distros that require building from sources. We do have such users and it would be a surprise for them. We really don't gain anything by changing the build platform requirement and making it different from the runtime requirement. It's just confusing. At some point in the future we might need to, but this current test jar bump ain't it. When Java 8 usage gets low enough, we can jump to 11, but surveys still show significant usage. |
|
This thread seems rather goalpost-moving...
Which Linux distro's is that? Even the notoriously-slow Debian Stable builds with JDK 21 (https://deb.debian.org/debian/pool/main/libc/libcommons-compress-java/libcommons-compress-java_1.27.1-2.dsc, https://packages.debian.org/trixie/default-jdk), 'oldstable' is jdk17 (even 'oldoldstable' is jdk11). Gentoo (https://packages.gentoo.org/packages/dev-java/commons-compress, https://packages.gentoo.org/packages/virtual/jdk) also seems to use newer JDK's.
Well, it holds us back from upgrading our build dependencies, leaving us on possibly-unsupported versions. In this case it might not be so bad (there's been pretty recent junit 5 releases), but it also disconnects us from upstream, making it effectively useless to provide feedback or contribute otherwise. The target audience that's impacted by a difference in build platform requirements vs runtime requirements seems unlikely to be too confused, I'm sure they'll manage. Anyway, I created #718 to go back to junit 5 for now. That said I really think we should at least reconsider our dependabot approach here (I see this has been discussed before in #707). |
2 participants
Bumps org.junit:junit-bom from 5.14.3 to 6.1.1.
Release notes
Sourced from org.junit:junit-bom's releases.
... (truncated)
Commits
0d85889Release 6.1.10363eeeFinalize 6.1.1 release notesa6d540aMove entry to 6.1.1 release notes69339d5Only pass timeout when publishing to avoid failure in nmcp plugindec2eb9Allow excluding engines from memory cleanup mode (#5786)a5f4270Publish sha256/sha512 checksums again but filter out signature ones (#5796)8213012Update plugin nmcp-settings to v1.6.0 (#5787)d1bf847Generate Javadoc for aggregator modulesd721de5Pass--no-fontstojavadocconventiond289ec6Restore original SetSystemProperty values in a ParameterizedTest (#5720)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)