chore: align catalog credential descriptors and fix metadata inconsistencies#2879
Merged
oscerd merged 1 commit intoJun 25, 2026
Merged
Conversation
…tencies Metadata-only consistency fixes across the Kamelet catalog (no runtime behaviour change): - jms-pooled-apache-artemis-sink/-source: add missing "format: password" to the broker password (the only two password properties carrying the credentials descriptor without format: password). - scp-sink, sftp-sink, sftp-source: mark privateKeyPassphrase as a secret (format: password + urn:camel:group:credentials), matching the sibling password property in the same Kamelets. - crypto-encrypt-action, crypto-decrypt-action, spring-rabbitmq-sink/-source: migrate the deprecated urn:alm:descriptor:com.tectonic.ui:password descriptor to urn:camel:group:credentials. - scp-sink: fix two property descriptions that referenced the "SFTP endpoint" (copy-paste) -> "SCP endpoint". - aws-redshift-source/-sink: normalise "RedShift" -> "Redshift". - aws-s3-event-based-source: quote the provider annotation value. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
davsclaus
approved these changes
Jun 25, 2026
This was referenced Jun 25, 2026
oscerd
added a commit
that referenced
this pull request
Jun 25, 2026
#2879 converted the deprecated urn:alm:descriptor:com.tectonic.ui:password x-descriptor to urn:camel:group:credentials on four properties that already carried the canonical urn:camel:group:credentials descriptor, leaving a duplicate entry (spotted by @apupier on #2881). Remove the redundant line so each property lists the credentials descriptor once. Affected: crypto-encrypt-action, crypto-decrypt-action, spring-rabbitmq-sink, spring-rabbitmq-source. A catalog-wide check confirms no property has duplicate x-descriptors. Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small, verified consistency fixes to the Kamelet catalog metadata. No runtime behaviour changes — every edit is JSON-schema metadata (credential descriptors /
format/ property descriptions / casing / quoting).Changes
Credential metadata
password(jms-pooled-apache-artemis-sink,-source): addedformat: password. These were the only twopassword:properties in the catalog carrying theurn:camel:group:credentialsdescriptor withoutformat: password; every other password property (includingjms-ibm-mq) pairs both.scp-sink,sftp-sink,sftp-source): addedformat: password+urn:camel:group:credentialstoprivateKeyPassphrase, matching the siblingpasswordfield in the same Kamelets. A key passphrase is a secret and should be masked / vault-bindable like one.crypto-encrypt-action,crypto-decrypt-action,spring-rabbitmq-sink,-source): dropped the deprecatedurn:alm:descriptor:com.tectonic.ui:passwordx-descriptor. These properties already carry the canonicalurn:camel:group:credentials, so the deprecated entry was redundant — removing it also avoids a duplicate descriptor (thanks @apupier for spotting the dup in an earlier revision of this PR).Documentation / metadata fixes
scp-sink: two property descriptions referred to the "SFTP endpoint" (copy-paste from the sftp Kamelets) → corrected to "SCP endpoint".aws-redshift-source/aws-redshift-sink: normalised "RedShift" → "Redshift" (the AWS product name) in descriptions.aws-s3-event-based-source: quoted thecamel.apache.org/providervalue ("Apache Software Foundation") — the only Kamelet of 250 leaving it unquoted.Deliberately NOT changed
oauth2ClientIdinhttp-secured-sink/-sourcecarriesformat: password. This is consistent with an established catalog convention — OAuth/cloud client IDs are masked across the catalog (azure-storage-blob ×8, google-calendar/mail/sheets, azure-datalake ×2, salesforce ×6, ms-exchange). Left as-is.Verification
script/validator(re-armed in ci: validate all Kamelets (remove early break in listKamelets) #2878) over all 250 Kamelets: no errors.x-descriptorsacross the 250 Kamelets../mvnw clean install -DskipTests(full reactor): passes.kamelets/is committed; thelibrary/camel-kameletsresource mirror is regenerated by the post-merge regen bot (cf. the "Regen for commit …" commits).AI-generated by Claude Code on behalf of Andrea Cosentino (@oscerd).