-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Drop and re-implement lockfile and python-daemon dependencies #65513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jscheffl
wants to merge
10
commits into
apache:main
Choose a base branch
from
jscheffl:bugfix/56769-drop-and-vendor-in-lockfile-and-python-daemon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
65e2e56
Drop and vendor-in lockfile and python-daemon dependencies
jscheffl f6adfb5
Add newsfragment
jscheffl 431c990
Review feedback from CoPilot
jscheffl 89b5195
Fix mypy
jscheffl 27e4812
Fix tests by Claude
jscheffl 892e6c3
Remove some un-needed complexity
jscheffl 1b5367a
Add NOTICE for the re-implementations
jscheffl f1b4152
Review feedback, plan for Airflow 3.3.0
jscheffl ce4dd86
Add two new modules to util allowlist
jscheffl ed8f8e2
Fix static checks
jscheffl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| Libraries ``lockfile`` and ``python-daemon`` have been removed as dependencies. | ||
|
|
||
| The relevant code has been vendored-in so that the dependencies are not needed. | ||
| If you plan to use an older Celery or Edge provider from older than May 2026, you will need | ||
| to install ``lockfile`` and ``python-daemon`` separately. | ||
| These packages are not required for Airflow itself, but are required for the Celery and Edge | ||
| providers in older versions. | ||
|
|
||
| TODO(jscheffl): Add a reference to min provider versions post next provider wave after this was merged prior Airflow 3.3.0. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.