Skip to content

feat: adding the option to add bundle version parameter on dag run trigger endpoint#61550

Open
itayweb wants to merge 53 commits into
apache:mainfrom
itayweb:feat-bundle-version-support-dagrun
Open

feat: adding the option to add bundle version parameter on dag run trigger endpoint#61550
itayweb wants to merge 53 commits into
apache:mainfrom
itayweb:feat-bundle-version-support-dagrun

Conversation

@itayweb

@itayweb itayweb commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

A new feature in the dag run REST API, adding the option to add bundle version parameter to trigger specific version.
Wasn't sure how can I add to this a unit test due to need a git repo/s3 bucket, let me know if needed


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Cursor] following the guidelines

@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:DAG-processing labels Feb 6, 2026
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from 5b3753a to eea1f7d Compare February 7, 2026 14:58
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from eea1f7d to a862cd3 Compare February 7, 2026 18:22
@itayweb itayweb requested a review from potiuk as a code owner February 7, 2026 18:22
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from a862cd3 to d47dcd4 Compare February 8, 2026 12:33
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch 2 times, most recently from 4aad19c to a87673a Compare February 8, 2026 19:51

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me.

Can you add unit tests to verify that behavior when we actually pass a 'bundle_version'.

I'd love a second look from versioning experts.

Comment thread airflow-core/src/airflow/serialization/definitions/dag.py Outdated

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

Please add the corresponding tests when you are convenient, thanks.

Comment thread airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the requested unit tests please so we can merge this.

Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py Outdated
@itayweb

itayweb commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

I've added the unit test, let me know what do you think 😄 sorry for the delay

@itayweb itayweb requested a review from pierrejeambrun May 25, 2026 16:06
@potiuk

potiuk commented May 26, 2026

Copy link
Copy Markdown
Member

@itayweb — There are 1 unresolved review thread(s) on this PR, and you have engaged with each one (post-review commits and/or in-thread replies). Could you confirm whether you believe the feedback is fully addressed and the PR is ready for maintainer review confirmation?

If yes, reply here (a short "yes / ready" is fine) and an Apache Airflow maintainer will pick the PR up from the review queue on the next sweep.

If you are still working on a thread, please reply with what is outstanding so the threads stay unresolved on purpose.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.


Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting

Itay Adler added 2 commits May 30, 2026 13:05
The schema.json was stale: it contained legacy top-level $defs
(DagRun, DagRunState, DagRunType, JsonValue, and nested asset
reference types) that the generator no longer emits after upstream
main restructured them. bundle_version also needed to land at the
correct offset in the generated output.
@itayweb

itayweb commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

@itayweb — There are 1 unresolved review thread(s) on this PR, and you have engaged with each one (post-review commits and/or in-thread replies). Could you confirm whether you believe the feedback is fully addressed and the PR is ready for maintainer review confirmation?

If yes, reply here (a short "yes / ready" is fine) and an Apache Airflow maintainer will pick the PR up from the review queue on the next sweep.

If you are still working on a thread, please reply with what is outstanding so the threads stay unresolved on purpose.

Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting

yes

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jun 3, 2026
@eladkal

eladkal commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

There are conflicts to resolve

@itayweb

itayweb commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

There are conflicts to resolve

Fixed, CI errors I am pretty sure not caused by my changes

Comment thread airflow-core/src/airflow/serialization/definitions/dag.py Outdated
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py Outdated
Comment thread airflow-core/src/airflow/serialization/definitions/dag.py Outdated
Comment thread airflow-core/src/airflow/serialization/definitions/dag.py
Comment thread airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py Outdated
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py Outdated
Comment thread airflow-core/src/airflow/api_fastapi/execution_api/datamodels/taskinstance.py Outdated
@eladkal

eladkal commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@itayweb can you handle the open comments?

@itayweb

itayweb commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@itayweb can you handle the open comments?

Yes, I've already handled them locally but I have some issues with the pre-commit hook when trying to rebase my branch

@ashb

ashb commented Jun 16, 2026

Copy link
Copy Markdown
Member

Please follow the commit guidelines, particularly the commit/PR subject should not contain conventional commits.

@eladkal eladkal requested a review from ephraimbuddy June 16, 2026 20:17
@itayweb

itayweb commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Please follow the commit guidelines, particularly the commit/PR subject should not contain conventional commits.

Oh didn't noticed you've changed your guidelines, do you prefer I'll squash all the existing commits to single commit to not include conventional commits?

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

uv.lock on main just moved via #68400 ("Bump clickhouse-connect>=1.3.0"), commit 844a892 and this PR currently conflicts.

Quickest fix:

git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-lease

Automated nudge — ignore if you're not ready to rebase. This comment is updated in place on future uv.lock bumps.

@guan404ming

Copy link
Copy Markdown
Member

Overall looks great. @itayweb could you help resolve the conflict, thanks!

@itayweb

itayweb commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Overall looks great. @itayweb could you help resolve the conflict, thanks!

Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:DAG-processing ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support bundle version param in trigger dag run endpoint

10 participants