feat: adding the option to add bundle version parameter on dag run trigger endpoint#61550
feat: adding the option to add bundle version parameter on dag run trigger endpoint#61550itayweb wants to merge 53 commits into
Conversation
5b3753a to
eea1f7d
Compare
eea1f7d to
a862cd3
Compare
a862cd3 to
d47dcd4
Compare
4aad19c to
a87673a
Compare
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the improvement!
Please add the corresponding tests when you are convenient, thanks.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Can you add the requested unit tests please so we can merge this.
|
I've added the unit test, let me know what do you think 😄 sorry for the delay |
|
@itayweb — There are 1 unresolved review thread(s) on this PR, and you have engaged with each one (post-review commits and/or in-thread replies). Could you confirm whether you believe the feedback is fully addressed and the PR is ready for maintainer review confirmation? If yes, reply here (a short "yes / ready" is fine) and an Apache Airflow maintainer will pick the PR up from the review queue on the next sweep. If you are still working on a thread, please reply with what is outstanding so the threads stay unresolved on purpose. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting |
The schema.json was stale: it contained legacy top-level $defs (DagRun, DagRunState, DagRunType, JsonValue, and nested asset reference types) that the generator no longer emits after upstream main restructured them. bundle_version also needed to land at the correct offset in the generated output.
yes |
|
There are conflicts to resolve |
Fixed, CI errors I am pretty sure not caused by my changes |
|
@itayweb can you handle the open comments? |
Yes, I've already handled them locally but I have some issues with the pre-commit hook when trying to rebase my branch |
|
Please follow the commit guidelines, particularly the commit/PR subject should not contain conventional commits. |
…n, drop bundle_version from Execution API
Oh didn't noticed you've changed your guidelines, do you prefer I'll squash all the existing commits to single commit to not include conventional commits? |
|
Quickest fix: git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-leaseAutomated nudge — ignore if you're not ready to rebase. This comment is updated in place on future |
|
Overall looks great. @itayweb could you help resolve the conflict, thanks! |
Done 👍 |
A new feature in the dag run REST API, adding the option to add bundle version parameter to trigger specific version.
Wasn't sure how can I add to this a unit test due to need a git repo/s3 bucket, let me know if needed
Was generative AI tooling used to co-author this PR?
Generated-by: [Cursor] following the guidelines