Revoke Slurm access when a membership or allocation is deactivated#545
Open
lahirujayathilake wants to merge 2 commits into
Open
Revoke Slurm access when a membership or allocation is deactivated#545lahirujayathilake wants to merge 2 commits into
lahirujayathilake wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users got cluster access when added to an allocation, but never lost it. Deactivating a member, removing them, or deactivating the allocation left them able to keep submitting jobs. The events for all of this were already being published, but nothing was listening to them.
What this does
Background check
The reconciler added in #544 only filled in missing access. It now also removes access that is no longer granted, so a missed event cannot leave someone with access forever.
Removing access is riskier than granting it, so the reconciler does nothing when it is unsure. It skips removal if no one on the cluster appears to have access (far more likely a failed lookup than a genuinely empty cluster), if a lookup it depends on fails, or if the account is not one Custos manages. It also leaves alone an allocation's own limits and members whose accounts were only just created.
Fixes #540