Skip to content

Single ping adcp improvements#803

Open
BecCowley wants to merge 11 commits into
aodn:masterfrom
BecCowley:single_ping_adcp
Open

Single ping adcp improvements#803
BecCowley wants to merge 11 commits into
aodn:masterfrom
BecCowley:single_ping_adcp

Conversation

@BecCowley

Copy link
Copy Markdown
Contributor

Long overdue updates that will allow the user to read in single-ping RDI ADCP data and subset into user-defined ensembles. Also includes 3-beam solution calculations update to the Beam2ENU code.
Add some PP routines for correlation magnitude, echo range, ringing bin removal.

@BecCowley

Copy link
Copy Markdown
Contributor Author

Can this PR please be reviewed and merged?

@bpasquer

bpasquer commented Aug 6, 2025

Copy link
Copy Markdown

@BecCowley
Your PR looks good from a coding perspective, and we can go ahead and merge it.
However, I wanted to check—were you expecting a more detailed technical review?

@BecCowley

Copy link
Copy Markdown
Contributor Author

@bpasquer I wasn't expecting a technical review. I have been using the branch these commits come from.
Only commit you might want to review is the change to the mcr call - this impacts on the main toolbox, it might cause issues for others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants