upgrade cluster config - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and configuration changes to the
src/data_index/defaults/cluster.pyfile, focusing on improving scalability, testability, and performance of the data indexing pipeline. The most significant changes include switching to a facility-subset-based live inventory source, updating file fetching logic, parameterizing table names for test isolation, and increasing resource allocations for Fargate clusters.Inventory Source and Data Fetching Improvements:
LiveS3InventorySourcewithLiveS3InventorySourceFacilitySubsetto enable inventory scanning in facility-based subsets, improving scalability and control over the number of files processed per facility. A newsubset_per_facilityparameter is set to 2,000. [1] [2]ThresholdFileFetcher, which delegates toS5CMDFetcherorS3Fetcherbased on file size, and introduced a configurable number of S5CMD workers (S5CMD_WORKERS = 8). [1] [2]Testability and Table Management:
run_index_clusterfunction to append the current Prefect flow run ID to Iceberg table names for both structured and unstructured sinks, ensuring test isolation and preventing table name collisions during concurrent test runs.StructuredMetadata.SCHEMA_VERSION.Cluster Resource Configuration:
transform_max_workersdefault to 32 for increased parallelism in transformation tasks. [1] [2]