Add basic unanimated webp encoding and decoding support#112
Merged
Conversation
…s86/nativewebp library
Owner
|
Hey thanks for this! I checked it out locally and it's working well. When you have a chance:
|
Contributor
Author
|
Thanks for the review! I hope, I covered both of your points with the latest commit on my branch. If there is still something I've missed I'm happy to push more commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic encoding and decoding support of unanimated webp image files.
WebP support was requested in #95 and I needed basic WebP support as well for a project of mine. I managed to introduce it quite easily thats why I thought about contributing it back to bild.
My implementation uses HugoSmits86/nativewebp library which adds a single dependency and depends on golang.org/x/image/webp.
I'd appreciate any kind of feedback on this since this is my first PR ever.