[AAP-82668] Add object-delete batch endpoint to API root test#1615
Open
john-westcott-iv wants to merge 1 commit into
Open
[AAP-82668] Add object-delete batch endpoint to API root test#1615john-westcott-iv wants to merge 1 commit into
john-westcott-iv wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe v1 root integration test no longer expects Changesv1 root response validation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
10 tasks
Contributor
|
@john-westcott-iv per Pinos comments in slack you will need to branch off of main instead of devel clean out all the old commits. |
DAB PR ansible/django-ansible-base#1050 removes the object-delete/ endpoint to the service-index API. This updates the no_shared_resource test case to remove that endpoint slug so the expected endpoint count matches. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
john-westcott-iv
force-pushed
the
AAP-82668
branch
from
July 16, 2026 18:31
d82990e to
6d4915d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/service-index/object-delete/to theno_shared_resourceexpected_slugs list intest_v1_rootobject-delete/batch/endpoint to the service-index APItest_v1_root[no_shared_resource]fails because the expected endpoint count (43) no longer matches the actual count (44)Test plan
test_v1_root[no_shared_resource]passes with DAB containing PR feat: config AUTHENTICATION_BACKENDS to use PrefixedUserAuthBackend #1050test_v1_root[with_shared_resource]continues to pass (unchanged)🤖 Generated with Claude Code
Summary by CodeRabbit