Skip to content

[AAP-82668] Add object-delete batch endpoint to API root test#1615

Open
john-westcott-iv wants to merge 1 commit into
ansible:mainfrom
john-westcott-iv:AAP-82668
Open

[AAP-82668] Add object-delete batch endpoint to API root test#1615
john-westcott-iv wants to merge 1 commit into
ansible:mainfrom
john-westcott-iv:AAP-82668

Conversation

@john-westcott-iv

@john-westcott-iv john-westcott-iv commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds /service-index/object-delete/ to the no_shared_resource expected_slugs list in test_v1_root
  • Fixes test failure caused by DAB PR [AAP-82668] Optimize RBAC cascade delete performance django-ansible-base#1050, which adds a new object-delete/batch/ endpoint to the service-index API
  • Without this change, test_v1_root[no_shared_resource] fails because the expected endpoint count (43) no longer matches the actual count (44)

Test plan

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated API root coverage to reflect the removal of the object-delete endpoint from the v1 response when shared resources are disabled.

@john-westcott-iv
john-westcott-iv requested a review from a team as a code owner July 14, 2026 21:18
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 456a0568-f877-40f9-bcc4-a88ae29e6eeb

📥 Commits

Reviewing files that changed from the base of the PR and between 51086aa and 6d4915d.

📒 Files selected for processing (1)
  • tests/integration/api/test_root.py
💤 Files with no reviewable changes (1)
  • tests/integration/api/test_root.py

📝 Walkthrough

Walkthrough

The v1 root integration test no longer expects /service-index/object-delete/ when shared resources are disabled. Other slug expectations and assertions remain unchanged.

Changes

v1 root response validation

Layer / File(s) Summary
Adjust no-shared-resource slug list
tests/integration/api/test_root.py
Removes /service-index/object-delete/ from the expected slugs for use_shared_resource=False.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title points to adding the endpoint, but the actual change removes the slug expectation from the test, so it is misleading. Update the title to reflect the real change, such as removing the object-delete slug expectation from the API root test.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description covers what changed, why it changed, and how to test it, with only optional template items left out.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@B-Whitt

B-Whitt commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@john-westcott-iv per Pinos comments in slack you will need to branch off of main instead of devel clean out all the old commits.

DAB PR ansible/django-ansible-base#1050 removes the object-delete/
endpoint to the service-index API. This updates the no_shared_resource
test case to remove that endpoint slug so the expected endpoint count matches.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants