Skip to content

fix: disable service account token automount for activation job pods #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheRealHaoLiu wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix: disable service account token automount for activation job pods #1598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/aap_eda/services/activation/engine/kubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ def _create_pod_template_spec(
spec_kwargs: dict = {
"restart_policy": "Never",
"containers": [container],
"automount_service_account_token": False,
Comment thread
mkanoor marked this conversation as resolved.
}
if request.credential:
self._create_secret(request, log_handler)
Expand Down
2 changes: 2 additions & 0 deletions tests/integration/services/activation/engine/test_kubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,7 @@ def capture_job(namespace, body):

spec = created_body.spec.template.spec
assert spec.service_account_name == "eda-workload"
assert spec.automount_service_account_token is False
labels = created_body.spec.template.metadata.labels
assert labels["app"] == "eda"
assert labels["job-name"] == engine.job_name
Expand Down Expand Up @@ -904,3 +905,4 @@ def test_engine_start_no_tolerations_by_default(
)
pod_spec = job_body.spec.template.spec
assert pod_spec.tolerations is None
assert pod_spec.automount_service_account_token is False
Loading