Skip to content

chore: remove spurious '/' in tekton regexp - #1573

Merged
ptoscano merged 1 commit into
ansible:mainfrom
ptoscano:fix-renovate
May 29, 2026
Merged

chore: remove spurious '/' in tekton regexp#1573
ptoscano merged 1 commit into
ansible:mainfrom
ptoscano:fix-renovate

Conversation

@ptoscano

@ptoscano ptoscano commented May 29, 2026

Copy link
Copy Markdown
Contributor

This should hopefully fix the matching of the references in the tekton configuration.

Summary by CodeRabbit

  • Chores
    • Updated dependency management configuration to correct pattern matching for tekton pipeline packages, narrowing targeting to the intended packages while preserving existing rule behaviors (manager scope and auto-merge remain unchanged). This is a configuration-only change that reduces incorrect matches and improves update accuracy and maintenance.

@ptoscano
ptoscano requested a review from a team as a code owner May 29, 2026 13:45
@coderabbitai

coderabbitai Bot commented May 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 87070fd0-afcd-40c4-88c7-895bb985623d

📥 Commits

Reviewing files that changed from the base of the PR and between 9cdfa0e and 1e4cfea.

📒 Files selected for processing (1)
  • renovate.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • renovate.json

📝 Walkthrough

Walkthrough

The PR corrects a regex pattern in renovate.json for matching tekton catalog pipeline packages. The matchPackageNames pattern is fixed to use a single forward slash separator (/pipeline/) instead of a trailing double slash, while matchManagers: ["tekton"] and automerge: true remain unchanged.

Changes

Renovate Configuration Regex Correction

Layer / File(s) Summary
Tekton pipeline package regex correction
renovate.json
The matchPackageNames regex pattern in the packageRules entry is corrected to properly match pipeline package names using a single forward slash; matchManagers: ["tekton"] and automerge: true remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and vague, lacking required template sections such as what/why the change was needed, how it addresses the issue, dependency/blocker information, and testing details. Expand the description to include: what exactly is being changed, why the spurious '/' causes matching failures, how the fix resolves it, any testing performed, and whether there are new dependencies or breaking changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing a spurious '/' from a Tekton regex pattern in renovate.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This should hopefully fix the matching of the references in the tekton
configuration.
@ptoscano
ptoscano enabled auto-merge (squash) May 29, 2026 13:48
@sonarqubecloud

Copy link
Copy Markdown

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (30bedfe) to head (1e4cfea).

@@           Coverage Diff           @@
##             main    #1573   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         244      244           
  Lines       11214    11214           
=======================================
  Hits        10337    10337           
  Misses        877      877           
Flag Coverage Δ
unit-int-tests-3.11 92.17% <ø> (ø)
unit-int-tests-3.12 92.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptoscano
ptoscano merged commit e823d44 into ansible:main May 29, 2026
7 checks passed
@ptoscano
ptoscano deleted the fix-renovate branch May 29, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants