Remove redundant linters, relax over-aggressive checks#192
Draft
AlanCoding wants to merge 2 commits into
Draft
Conversation
Drop flake8 + wemake-python-styleguide + darglint entirely — ruff with select=ALL already covers everything flake8 does, and WPS was the primary source of noqa whack-a-mole that made contributions painful. Reduce mypy from 3 runs (py311/312/313) to 1 run (py311, the lowest supported version). Version-specific typing bugs are rare and not worth 3x the CI time. Relax pylint: drop fail-under from 10 (perfect) to 9, un-ban single-letter loop variables (i, j, k, x, y, f, e, _). Remove nitpick (meta-linter that lints linter configs). Drop codecov coverage targets from 100% to 90% for patch and test coverage. Remove redundant config files: .flake8, .darglint, .isort.cfg (ruff handles import sorting), .pep8, nitpick-style.toml. Clean up 75 noqa comments across source and test files that were only needed for WPS/DAR/flake8-specific codes. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
select=ALLalready covers everything flake8 does. WPS was the primary source of# noqawhack-a-mole that made contributions painful (75 noqa comments removed in this PR).i,j,k, etc.)..flake8,.darglint,.isort.cfg,.pep8,nitpick-style.toml. Down from 15 config files to 9.Motivation
The linting setup was the most heavily instrumented Python project I've seen: 30+ checks, 5 overlapping linters, 15 config files. A 3-line fix required navigating WPS opinions, darglint docstring params, 3 mypy runs, and 100% patch coverage — multiple hours of linter whack-a-mole. This made contributions prohibitively expensive while checking cosmetics (quote style, trailing commas) rather than things that matter (architecture, correctness, security).
What remains: ruff (with
select=ALL), mypy (strict, 1 run), pylint (relaxed), plus standard pre-commit hooks (codespell, yamllint, shellcheck, etc.). This is still a well-guarded codebase — just not a hostile one.Note
This same cleanup should be duplicated to
awx_plugins.interfaceswhich has an identical linting setup.Test plan
🤖 Generated with Claude Code