fix proxy jump behavior#307
Open
vadvolo wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@Tishka17 could you please review these PR for me, please? |
Tishka17
reviewed
Jun 17, 2026
| realHost := ssh_config.Get(host, "Hostname") | ||
| if len(realHost) > 0 { | ||
| connectHost = realHost | ||
| ip = netip.Addr{} |
Contributor
There was a problem hiding this comment.
This line was needed to ensure we conntect to Hostname from config, not IP recieved from client. I see that cfg.ip is never used, does this case work correctly?
Contributor
Author
There was a problem hiding this comment.
I seems I need to use cfg.ip instead of ip it in line 67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue #306