Enhances ignore pattern handling with gitignore support#7
Enhances ignore pattern handling with gitignore support#7alexstewartja wants to merge 11 commits into
Conversation
Co-authored-by: alexstewartja <[email protected]>
Co-authored-by: alexstewartja <[email protected]>
Co-authored-by: alexstewartja <[email protected]>
Co-authored-by: alexstewartja <[email protected]>
…lity Co-authored-by: alexstewartja <[email protected]>
…enhanced ignore handling Co-authored-by: alexstewartja <[email protected]>
Co-authored-by: alexstewartja <[email protected]>
…94-acca-d9b5c2e95a97 Replace manual .gitignore parsing with robust ignore package handling in CheckpointManager
Corrected a long-running typo
|
@andycufari Conflicts resolved |
|
Hi @alexstewartja, Thank you for this comprehensive improvement to our ignore pattern handling! The migration to the ignore package and full gitignore compliance is exactly what we need. I have a question about the design decision to maintain both .gitignore support and ClaudePoint-level ignore patterns (additionalIgnores). Current approach in your PR:
Question: What's the reasoning behind having both systems? Most tools use a single ignore mechanism. Alternative approach: // Use .gitignore for everything else This would: Use case question: Are there specific scenarios where additionalIgnores would be needed that can't be handled by adding patterns to .gitignore? Looking forward to your thoughts on this design decision! Best, |
|
Hey @andycufari, Thanks for taking a look! I'll try to answer your question as concisely as possible. The preservation of A notable example is my use case where I additionally ignore My checkpoint and version control workflows differ considerably, hence, advanced usage. |
|
@andycufari You are welcome to test this PRs functionality with: claude mcp add claudepoint -- npx -y github:alexstewartja/ClaudePoint |
|
@andycufari I see you silently ignored (pun intended) this PR and implemented the |
This pull request improves file exclusion logic by leveraging
.gitignorefiles for defining ignore patterns.Key improvements:
ignorepackageThis change removes the hardcoded ignore patterns and relies on
.gitignorefor more robust and configurable behavior.