Rename workspace_dir to shared_dir and add sales analyst example#4
Merged
Merged
Conversation
Clarify that commands run in-container with a host bind mount at /shared, drop docker inspect for sandbox IDs, and add a sales analyst example with sample CSV data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace_dirtoshared_dirand documents the host↔container bind mount at/shared(shell cwd inside the container).sandbox.idinstead ofdocker inspect, and removes unusedinspect_container_idhelper.docker runprofile) while keeping memory/CPU/PID limits.examples/sales_analyst.pywith sampleexamples/data/sales.csv, and updates the pizza agent + README accordingly.Breaking changes
workspace_dir→shared_dir/workspace→/sharedTest plan
pytest tests/passes locallyDockerSandbox(shared_dir="examples/data")starts a container and mounts the host folder at/sharedexamples/pizza_agent.py(network required) and confirmrecipe.mdappears underexamples/data/examples/sales_analyst.pyand confirmsales_report.md+img/are produced in the shared folderMade with Cursor