Add METISSE for stellar evolution#1254
Conversation
# Conflicts: # .github/workflows/test-framework.yml # .github/workflows/test-seba.yml # src/amuse/ext/concurrent.py
rieder
added
the
area: community_code
LourensVeen
left a comment
LourensVeen
left a comment
There was a problem hiding this comment.
Looking pretty good, but I have some comments. Also, it doesn't seem like there are any tests? Could we add at least some basic ones that instantiate the code, put some particles in, and do a simple calculation?
| @@ -0,0 +1,44 @@ | |||
| [project] | |||
There was a problem hiding this comment.
There should not be a package here, just a forward in amuse/community/metisse/init.py and interface.py, like for the other codes.
| @@ -0,0 +1,185 @@ | |||
| import logging | |||
There was a problem hiding this comment.
Should this go with the other examples in src/amuse/examples rather than here?
| @@ -0,0 +1,259 @@ | |||
| """ | |||
There was a problem hiding this comment.
Same as for the other example
|
|
||
| Scientific papers written using this module should reference the paper | ||
|
|
||
| "Comprehensive analytic formulae for stellar evolution as a function |
There was a problem hiding this comment.
We have a mechanism for this, right? Should this go into the docstring in interface.py with the other references there?
|
|
||
|
|
||
| # Downloading the code | ||
| ##### Remove if not needed ##### |
There was a problem hiding this comment.
These ##### comments are intended to be removed once implemented.
| @@ -0,0 +1 @@ | |||
| fortran mpi No newline at end of file | |||
There was a problem hiding this comment.
This needs download, tar, and gunzip for downloading and extracting.
| RANLIB = @RANLIB@ | ||
| DOWNLOAD = @DOWNLOAD@ | ||
| TAR = @TAR@ | ||
| UNZIP = @UNZIP@ |
There was a problem hiding this comment.
We don't need most of these.
|
|
||
|
|
||
| # AMUSE framework libraries | ||
| STOPCOND_CFLAGS = @STOPCOND_CFLAGS@ |
There was a problem hiding this comment.
I think adding stopping conditions is a planned extension? Then we could leave the applicable one. But we're probably not using AMUSE_MPI, SIMPLE_HASH, or G6LIB? Then those should be removed to avoid confusion.
| # Find AMUSE libraries | ||
| AMUSE_LIB_STOPCOND() | ||
| AMUSE_LIB_STOPCONDMPI() | ||
| AMUSE_LIB_AMUSE_MPI() |
There was a problem hiding this comment.
See comment on config.mk.in
|
|
||
| ##### Wrap these into language macros as needed ##### | ||
| ##### MPI is always needed to build the worker ##### | ||
| AX_MPI() |
There was a problem hiding this comment.
As the comment indicates, this goes in between the AC_LANG_PUSH and AC_LANG_POP macros to indicate that we want to use MPI from Fortran.
2 participants
This PR adds METISSE (https://github.com/TeamMETISSE/METISSE) as a community code.
Still needs a way to download default stellar tracks but should otherwise work.