Skip to content

[ENG-4127] feat(connectwise): Communication items#654

Merged
Cobalt0s merged 4 commits into
cobalt0s/connectwise-custom-fieldsfrom
cobalt0s/connectwise-communication-items
Jul 22, 2026
Merged

[ENG-4127] feat(connectwise): Communication items#654
Cobalt0s merged 4 commits into
cobalt0s/connectwise-custom-fieldsfrom
cobalt0s/connectwise-communication-items

Conversation

@Cobalt0s

@Cobalt0s Cobalt0s commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Add description on contacts communication items.

Screenshot

image image image image image image image

@linear

linear Bot commented Jul 20, 2026

Copy link
Copy Markdown

ENG-4127

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Cobalt0s
Cobalt0s force-pushed the cobalt0s/connectwise-communication-items branch from 26d254f to c65f7dd Compare July 20, 2026 23:15
@Cobalt0s
Cobalt0s marked this pull request as ready for review July 20, 2026 23:15
@Cobalt0s
Cobalt0s requested a review from anushat05 July 20, 2026 23:15
@anushat05

Copy link
Copy Markdown
Contributor

I took a pass at the ConnectWise docs and put my changes on a separate branch so it's easy to diff here. Didn't push to your branch directly, if you like it, pull it in.

Main feedback: the page was pitched a layer too low, more like an API reference than a builder guide. I made it short, naming convention plus one example, no raw API payloads and trimmed both ConnectWise sections to match.

  • Custom Fields: kept the customField<ID> + mapToName explanation, the read example, and the CW-specific notes (only send what you're changing, null to clear, find the ID in a read response). Dropped the mappedFields block and the separate create/PUT/PATCH payloads.
  • Communication Items: leads with the field table and how to map; trimmed the PUT-vs-PATCH narrative and defaultFlag/array-index detail; moved raw JSON Patch into a small "Advanced" note.

Three things to confirm before merge:

  1. The communications-items write section says "an update changes only the fields you send." That's the target behavior but the current code still full-replaces on a flat update, so this should land with the partial-update fix, not before.
  2. I removed the "removing a default auto-promotes another item" claim since I don't think we verified it. Add it back if you have.
  3. I kept the AMPERSAND- field names since that's what builders type, just flagging it's a conscious call to expose that prefix.

@Cobalt0s
Cobalt0s merged commit a5a122d into cobalt0s/connectwise-custom-fields Jul 22, 2026
1 of 2 checks passed
@Cobalt0s
Cobalt0s deleted the cobalt0s/connectwise-communication-items branch July 22, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants