fix failing build#30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes TypeScript compilation errors that caused
npm run buildto fail.Why?
The project build was broken after stricter TypeScript/ESLint type checking was introduced. Three files no longer compiled:
scripts/migrate.ts— Kysely'sMigratorreturnserrorasunknown, but the local variable was typedError | undefined.test/api_tests/helper.ts— The mocked responsebodywas typed asRecord<string, unknown>, which prevented downstream casts toPaginatedResponse<T>.test/api_tests/person.test.ts—body.errorsis optional (unknown[] | undefined), so accessing.lengthdirectly violated strict null checks.How?
errortype tounknowninscripts/migrate.ts.bodytype tounknownintest/api_tests/helper.ts.body.errors.lengthwithbody.errors?.lengthintest/api_tests/person.test.ts.Testing?
npm run build✅npm run lint✅npm test✅ (32/32 tests passing)Screenshots (optional)
N/A
Anything Else?
N/A
AI Summary (optional)
Fixed TypeScript build errors by aligning variable types with Kysely's API and applying optional chaining for nullable error arrays.