refactor: adopt go 1.27 idioms - #4935
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
- errors.AsType instead of a declared target var with errors.As - promoted fields set directly in composite literals (docker HostConfig, network.Summary, k8s TypeMeta/ObjectMeta, embedded test fixtures) - strings.Cut instead of strings.Split for env var name parsing Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
|
Reviewed. Clean, mechanical refactor, no functional changes.
No bugs, security, or test coverage concerns. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4934 now that the toolchain is on go 1.27.
errors.AsTypeinstead of declaring a target var and callingerrors.AsHostConfigresources,network.Summary, k8sTypeMeta/ObjectMeta, embedded test fixtures)strings.Cutinstead ofstrings.Splitwhen splitting env vars on=go mod tidy, which had drifted on mastergo build,go vetandgo test ./internal/...all pass on 1.27.0.