Skip to content

Add Tekton CI support in CIQualityGatesAssessor#437

Open
mmorhun wants to merge 1 commit into
ambient-code:mainfrom
mmorhun:add-tekton-ci
Open

Add Tekton CI support in CIQualityGatesAssessor#437
mmorhun wants to merge 1 commit into
ambient-code:mainfrom
mmorhun:add-tekton-ci

Conversation

@mmorhun
Copy link
Copy Markdown

@mmorhun mmorhun commented May 15, 2026

Assisted-by: Claude

Description

Adds basic support for Pipeline-as-Code CI.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

Related Issues

N/A

Changes Made

  • Check for .tekton directory in the repository config to detect Pipelines-as-Code CI / Konflux
  • Check for Tekton pipelines that run on PR
  • Unit tests added

Testing

  • Unit tests pass (pytest)
  • Integration tests pass
  • Manual testing performed
  • No new warnings or errors

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

Summary by CodeRabbit

  • New Features

    • Tekton Pipelines-as-Code support added, enabling detection of pull-request triggers via both annotation-based and expression-based configurations for improved CI quality gates evaluation.
  • Tests

    • Comprehensive unit tests added to validate Tekton CI trigger detection across multiple configuration formats and scenarios.

Signed-off-by: Mykola Morhun <[email protected]>
Assisted-by: Claude
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 5a28ef99-5f06-46eb-bfbc-9c9f39fd48db

📥 Commits

Reviewing files that changed from the base of the PR and between 312c99a and 9330f0e.

📒 Files selected for processing (2)
  • src/agentready/assessors/testing.py
  • tests/unit/test_assessors_testing.py

📝 Walkthrough

Walkthrough

This PR extends CI quality gates assessment to recognize Tekton Pipelines-as-Code by adding .tekton directory scanning and parsing pipelinesascode.tekton.dev annotations to detect pull-request triggers—supporting both on-event string/array forms and on-cel-expression CEL expressions.

Changes

Tekton PR Trigger Detection

Layer / File(s) Summary
Tekton PR trigger detection
src/agentready/assessors/testing.py, tests/unit/test_assessors_testing.py
Config path .tekton is added to CI scanner, detection logic reads Tekton pipeline YAML and extracts PR triggers from on-event annotations (string and array) and on-cel-expression CEL expressions. Test coverage includes positive cases (simple/array/complex expressions) and negative cases (push-only triggers).
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title is descriptive but doesn't follow Conventional Commits format (missing type prefix like 'feat'). Reformat the title as 'feat(ci): Add Tekton CI support in CIQualityGatesAssessor' to comply with Conventional Commits requirements.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant