Skip to content

vendor._lattice: delay OE for ECP5 DDR buffer - #1668

Merged
whitequark merged 1 commit into
amaranth-lang:mainfrom
whitequark:ecp5-ddr-buffer-latency
Jul 12, 2026
Merged

vendor._lattice: delay OE for ECP5 DDR buffer#1668
whitequark merged 1 commit into
amaranth-lang:mainfrom
whitequark:ecp5-ddr-buffer-latency

Conversation

@whitequark

@whitequark whitequark commented Jul 5, 2026

Copy link
Copy Markdown
Member

Fixes #1667.

Tested on hardware in LFE5U-25F.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.25%. Comparing base (c9be3e4) to head (0695fd1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1668   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files          44       44           
  Lines       11521    11521           
  Branches     2244     2244           
=======================================
  Hits        10513    10513           
  Misses        846      846           
  Partials      162      162           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@whitequark

Copy link
Copy Markdown
Member Author

Reading Lattice models:

  • /usr/local/diamond/3.12/ispfpga/verilog/data/ecp5u/ODDRX1F.v confirms the additional 2 register stages
  • /usr/local/diamond/3.12/ispfpga/verilog/data/machxo2/ODDRXE.v indicates no additional register stages
  • I don't have a model for Nexus on hand

@whitequark
whitequark force-pushed the ecp5-ddr-buffer-latency branch 2 times, most recently from 8a8a3f8 to 9255619 Compare July 5, 2026 19:57
@whitequark
whitequark added this pull request to the merge queue Jul 12, 2026
@whitequark whitequark changed the title vendor._lattice: delay OE for ECP5/MachXO2/Nexus DDR buffer vendor._lattice: delay OE for ECP5 DDR buffer Jul 12, 2026
@whitequark
whitequark removed this pull request from the merge queue due to a manual request Jul 12, 2026
@whitequark
whitequark added this pull request to the merge queue Jul 12, 2026
Comment thread amaranth/vendor/_lattice.py Outdated
@whitequark
whitequark removed this pull request from the merge queue due to a manual request Jul 12, 2026
@whitequark
whitequark force-pushed the ecp5-ddr-buffer-latency branch from 9255619 to 0695fd1 Compare July 12, 2026 16:00
@whitequark
whitequark enabled auto-merge July 12, 2026 16:00
@whitequark
whitequark added this pull request to the merge queue Jul 12, 2026
Merged via the queue into amaranth-lang:main with commit c5680ba Jul 12, 2026
21 of 23 checks passed
@whitequark
whitequark deleted the ecp5-ddr-buffer-latency branch July 12, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

ECP5 DDRBuffer has broken OE handling

2 participants