Apply migrations one transaction per migration - #86
Open
tominal wants to merge 1 commit into
Open
Conversation
drizzle-orm's migrate() runs all pending migrations in a single transaction. Postgres refuses to use a newly added enum value in the transaction that added it (error 55P04), so on a fresh database the batch fails: migration 0013 adds capture_status 'dead' and 0017 indexes on it. Existing databases never hit this because they migrated incrementally, committing between runs. Replace the built-in migrator with a small one that commits per migration, reproducing that incremental behaviour. Bookkeeping still uses drizzle's drizzle.__drizzle_migrations table, so existing databases and drizzle-kit stay compatible. Verified on a fresh database: all 30 migrations apply with no 55P04, and a re-run applies none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another PR for another lil first-time setup friction!
drizzle-orm's migrate() runs all pending migrations in a single transaction. PostgreSQL refuses to use a newly added enum value in the transaction that added it (error 55P04), so on a fresh database the batch fails: migration 0013 adds capture_status 'dead' and 0017 indexes on it. Existing databases never hit this because they migrated incrementally, committing between runs.
Replace the built-in migrator with a small one that commits per migration, reproducing that incremental behavior. Bookkeeping still uses drizzle's drizzle.__drizzle_migrations table, so existing databases and drizzle-kit stay compatible. Verified on a fresh database: all 30 migrations apply with no 55P04, and a re-run applies none.