[design] 로고 파일 변경#43
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthrough로고를 공용 React 컴포넌트로 추출하고, index.html의 파비콘·제목을 "알터" 브랜딩으로 갱신한 뒤, LoginPage와 Navbar에서 이를 사용하도록 통합. Changes로고 컴포넌트화 및 브랜딩 통합
🎯 Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly Related PRs
Suggested Reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@index.html`:
- Line 6: Replace the SVG used for the apple-touch-icon with an iOS-compatible
PNG file: update the <link rel="apple-touch-icon"> href (currently pointing to
/alter_logo.svg) to reference your 180x180 PNG touch icon (e.g.,
/alter_logo-180.png) so iOS Safari can reliably display the home screen icon.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 455454ac-dd08-4960-9268-d2e004acae94
⛔ Files ignored due to path filters (4)
public/alter_logo.svgis excluded by!**/*.svgpublic/vite.svgis excluded by!**/*.svgsrc/assets/Alter-logo.pngis excluded by!**/*.pngsrc/assets/alter_logo.svgis excluded by!**/*.svg
📒 Files selected for processing (4)
index.htmlsrc/pages/login/index.tsxsrc/shared/ui/common/AlterLogo.tsxsrc/shared/ui/common/Navbar.tsx
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> | ||
| <link rel="icon" type="image/svg+xml" href="/alter_logo.svg" /> | ||
| <link rel="apple-touch-icon" href="/alter_logo.svg" /> |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Does Safari on iOS fully support SVG files for <link rel="apple-touch-icon">, or is PNG still the recommended format?
💡 Result:
No—iOS Safari does not fully support SVG files as the value for link rel="apple-touch-icon". PNG (or other raster formats) is still the recommended/compatible approach for apple-touch-icon. Evidence: - iOS Safari’s apple-touch-icon guidance and validation rules assume PNG “apple-touch-icon” images (not SVG). For example, the webhint hint for apple-touch-icons checks that each declared apple-touch-icon is “a PNG” of the appropriate resolution [1]. - The historical/behavioral documentation for iOS “touch icons” describes searching for filenames like apple-touch-icon-*.png (and fallbacks), not SVG [2]. Related note (often confused with apple-touch-icon): Safari’s support for SVG is real for other icon link mechanisms (e.g., SVG favicons via rel="icon" for newer Safari versions), but that’s different from the apple-touch-icon specifically used for iOS home-screen/pinned touch icon behavior [3].
Citations:
- 1: https://webhint.io/docs/user-guide/hints/hint-apple-touch-icons/
- 2: https://mathiasbynens.be/notes/touch-icons
- 3: https://caniuse.com/link-icon-svg
index.html(6행) apple-touch-icon은 SVG 대신 iOS 호환 PNG로 교체
iOS Safari는 rel="apple-touch-icon"에 SVG를 안정적으로 처리하지 않아 홈 화면 아이콘이 누락될 수 있습니다(호환성 권장 포맷은 PNG).
- Line 6:
/alter_logo.svg→ 프로젝트의 180x180 등 PNG touch icon 파일을href로 지정하세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@index.html` at line 6, Replace the SVG used for the apple-touch-icon with an
iOS-compatible PNG file: update the <link rel="apple-touch-icon"> href
(currently pointing to /alter_logo.svg) to reference your 180x180 PNG touch icon
(e.g., /alter_logo-180.png) so iOS Safari can reliably display the home screen
icon.
ID
변경 내용
구현 사항
구현 시연 (필요 시)