Skip to content

[design] 로고 파일 변경#43

Merged
dohy-eon merged 1 commit into
devfrom
design/ALT-236
May 26, 2026
Merged

[design] 로고 파일 변경#43
dohy-eon merged 1 commit into
devfrom
design/ALT-236

Conversation

@dohy-eon
Copy link
Copy Markdown
Member

@dohy-eon dohy-eon commented May 25, 2026

ID

  • ALT-236

변경 내용

  • 로고 교체

구현 사항

  • Alter-logo.png / public/vite.svg 제거 후 alter_logo.svg 사용
  • AlterLogo 공용 컴포넌트 추가 (Navbar, 로그인 페이지)
  • index.html favicon·apple-touch-icon 및 문서 타이틀을 알터로 변경

구현 시연 (필요 시)

image image image

@dohy-eon dohy-eon requested review from kim3360 and limtjdghks May 25, 2026 08:40
@dohy-eon dohy-eon self-assigned this May 25, 2026
@vercel
Copy link
Copy Markdown

vercel Bot commented May 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
alter-client Ready Ready Preview, Comment May 25, 2026 8:40am

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

📝 Walkthrough

Walkthrough

로고를 공용 React 컴포넌트로 추출하고, index.html의 파비콘·제목을 "알터" 브랜딩으로 갱신한 뒤, LoginPage와 Navbar에서 이를 사용하도록 통합.

Changes

로고 컴포넌트화 및 브랜딩 통합

Layer / File(s) Summary
AlterLogo 공용 컴포넌트 정의
src/shared/ui/common/AlterLogo.tsx
SVG 로고를 렌더링하는 새로운 AlterLogo 컴포넌트 생성, className 병합(cn 유틸)과 alt 기본값('알터 로고') 포함.
HTML 브랜딩 및 메타데이터
index.html
파비콘 및 애플 터치 아이콘을 /alter_logo.svg로 변경, 페이지 제목을 알터로 갱신.
LoginPage 및 Navbar 로고 마이그레이션
src/pages/login/index.tsx, src/shared/ui/common/Navbar.tsx
이미지 파일 직접 import를 제거하고 AlterLogo 컴포넌트로 전환, 각 파일의 import 구문과 JSX 렌더링 로직 갱신.

🎯 Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~5 minutes


Possibly Related PRs

  • alter-app/alter-client#7: 동일한 src/shared/ui/common/Navbar.tsx 파일의 로고 렌더링 방식을 수정하는 PR로, 같은 컴포넌트 레벨에서 겹침.

Suggested Reviewers

  • kim3360
  • limtjdghks
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경 내용과 직결되어 있습니다. 로고 파일 변경이 주요 변경사항이며, 제목은 간결하고 명확합니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed PR 설명이 템플릿 구조를 따르고 ID, 변경 내용, 구현 사항, 구현 시연을 포함했으나 구체적인 구현 상세 설명 및 참고 사항이 부족합니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch design/ALT-236

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@index.html`:
- Line 6: Replace the SVG used for the apple-touch-icon with an iOS-compatible
PNG file: update the <link rel="apple-touch-icon"> href (currently pointing to
/alter_logo.svg) to reference your 180x180 PNG touch icon (e.g.,
/alter_logo-180.png) so iOS Safari can reliably display the home screen icon.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 455454ac-dd08-4960-9268-d2e004acae94

📥 Commits

Reviewing files that changed from the base of the PR and between 17b84c0 and c8ff4b4.

⛔ Files ignored due to path filters (4)
  • public/alter_logo.svg is excluded by !**/*.svg
  • public/vite.svg is excluded by !**/*.svg
  • src/assets/Alter-logo.png is excluded by !**/*.png
  • src/assets/alter_logo.svg is excluded by !**/*.svg
📒 Files selected for processing (4)
  • index.html
  • src/pages/login/index.tsx
  • src/shared/ui/common/AlterLogo.tsx
  • src/shared/ui/common/Navbar.tsx

Comment thread index.html
<meta charset="UTF-8" />
<link rel="icon" type="image/svg+xml" href="/vite.svg" />
<link rel="icon" type="image/svg+xml" href="/alter_logo.svg" />
<link rel="apple-touch-icon" href="/alter_logo.svg" />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

Does Safari on iOS fully support SVG files for <link rel="apple-touch-icon">, or is PNG still the recommended format?

💡 Result:

No—iOS Safari does not fully support SVG files as the value for link rel="apple-touch-icon". PNG (or other raster formats) is still the recommended/compatible approach for apple-touch-icon. Evidence: - iOS Safari’s apple-touch-icon guidance and validation rules assume PNG “apple-touch-icon” images (not SVG). For example, the webhint hint for apple-touch-icons checks that each declared apple-touch-icon is “a PNG” of the appropriate resolution [1]. - The historical/behavioral documentation for iOS “touch icons” describes searching for filenames like apple-touch-icon-*.png (and fallbacks), not SVG [2]. Related note (often confused with apple-touch-icon): Safari’s support for SVG is real for other icon link mechanisms (e.g., SVG favicons via rel="icon" for newer Safari versions), but that’s different from the apple-touch-icon specifically used for iOS home-screen/pinned touch icon behavior [3].

Citations:


index.html(6행) apple-touch-icon은 SVG 대신 iOS 호환 PNG로 교체

iOS Safari는 rel="apple-touch-icon"에 SVG를 안정적으로 처리하지 않아 홈 화면 아이콘이 누락될 수 있습니다(호환성 권장 포맷은 PNG).

  • Line 6: /alter_logo.svg → 프로젝트의 180x180 등 PNG touch icon 파일을 href로 지정하세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@index.html` at line 6, Replace the SVG used for the apple-touch-icon with an
iOS-compatible PNG file: update the <link rel="apple-touch-icon"> href
(currently pointing to /alter_logo.svg) to reference your 180x180 PNG touch icon
(e.g., /alter_logo-180.png) so iOS Safari can reliably display the home screen
icon.

@dohy-eon dohy-eon merged commit eedaa02 into dev May 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants