Skip to content

Restore EDC review regression fixes#151

Merged
almogdepaz merged 1 commit into
terminal_optimization2from
edc-review-restored-fixes
May 25, 2026
Merged

Restore EDC review regression fixes#151
almogdepaz merged 1 commit into
terminal_optimization2from
edc-review-restored-fixes

Conversation

@almogdepaz

Copy link
Copy Markdown
Owner

summary

Restores the regression fixes called out by review-HEAD.md for terminal_optimization2.

restored fixes and why

  • restored the isolated Ralph structured JSON response channel (.ralph-response.json + schema) because parsing <done> / <subtasks> from mixed stdout/stderr lets echoed prompts, tool output, or malicious task text mark work complete incorrectly.
  • restored Ralph worker/response/agent/prompt/git-exclude regression tests because the previous tests were added for real incidents (fix ralph structured agent responses, worker response regressions, transient file staging) and parser-only tests did not cover the repo-mutating worker path.
  • restored runner-owned transient git excludes (.ralph-*, response/schema/srt temp files, progress.txt) because broad agent commits like git add -A can otherwise commit logs, prompt artifacts, and runner state.
  • restored Codex-specific srt allowances (~/.codex, chatgpt.com) because Codex initializes mutable state and network access there under the default Ralph sandbox; removing this made agent: codex unreliable.
  • restored negative srt socket policy assertions and broker startup diagnostics because default Ralph srt must not get broad Unix socket access; without the diagnostic, operators are pushed toward unsafe allowAllUnixSockets workarounds.
  • restored Ralph opt-in docs because the UI still hides Ralph controls behind Settings → Ralph Loop → Enable Ralph Loop.
  • corrected the Ralph skill description because Wolfpack no longer runtime-injects .claude/skills/wolfpack-ralph; claiming that misleads contributors.
  • added deterministic reconnect-banner e2e coverage during a browser network outage because fast broker reconnect tests can skip the visible banner assertion without proving slow/outage UX.

verification

  • bunx tsc --noEmit -p .
  • bunx tsc --noEmit -p public/
  • bun test
  • cargo test --manifest-path broker/Cargo.toml
  • bunx playwright test tests/e2e/reconnect.e2e.ts --grep "network outage|shows reconnecting banner"
  • git diff --check && git diff --cached --check

notes

review-HEAD.md and WOLFPACK_RESTART_DEBUG_STATUS.md were left untracked and not included in this PR.

@almogdepaz almogdepaz merged commit ef53a72 into terminal_optimization2 May 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant