Restore EDC review regression fixes#151
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Restores the regression fixes called out by
review-HEAD.mdforterminal_optimization2.restored fixes and why
.ralph-response.json+ schema) because parsing<done>/<subtasks>from mixed stdout/stderr lets echoed prompts, tool output, or malicious task text mark work complete incorrectly.fix ralph structured agent responses, worker response regressions, transient file staging) and parser-only tests did not cover the repo-mutating worker path..ralph-*, response/schema/srt temp files,progress.txt) because broad agent commits likegit add -Acan otherwise commit logs, prompt artifacts, and runner state.~/.codex,chatgpt.com) because Codex initializes mutable state and network access there under the default Ralph sandbox; removing this madeagent: codexunreliable.allowAllUnixSocketsworkarounds..claude/skills/wolfpack-ralph; claiming that misleads contributors.verification
bunx tsc --noEmit -p .bunx tsc --noEmit -p public/bun testcargo test --manifest-path broker/Cargo.tomlbunx playwright test tests/e2e/reconnect.e2e.ts --grep "network outage|shows reconnecting banner"git diff --check && git diff --cached --checknotes
review-HEAD.mdandWOLFPACK_RESTART_DEBUG_STATUS.mdwere left untracked and not included in this PR.