Prevent lock of main thread - #2550
Open
PlayBoy31 wants to merge 1 commit into
Open
Conversation
if the seperate thread is making a query but the SQL server is busy, and if a that time the main thread is doing a SQL_EscapeString (in a sp plugin) then the main thread is waiting for the lock. It is no necessary to do this lock here, its not a query
Member
|
Have you confirmed that the internal implementation is okay with this being used concurrently with other MySQL API calls? |
Contributor
Author
Yes, I have tested the fix and it fix the regrtession i observed since the #2528 (=> my game server was laggy when doing large operations on the SQL server, both are not the same machine) I have lots of MYSQL API call in my plugins, all is fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if the seperate thread is making a query but the SQL server is busy, and if a that time the main thread is doing a SQL_EscapeString (in a sp plugin) then the main thread is waiting for the lock. It is no necessary to do this lock here, its not a query.