SIM_LOG_DIR points to "${SCRIPT_DIR:?}"/log rather then /etc/astra-sim which requires sudo priviledges.#255
Open
marcodamico wants to merge 2 commits into
Open
SIM_LOG_DIR points to "${SCRIPT_DIR:?}"/log rather then /etc/astra-sim which requires sudo priviledges.#255marcodamico wants to merge 2 commits into
marcodamico wants to merge 2 commits into
Conversation
…m which requires sudo priviledges.
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #254 by changing SIM_LOG_DIR in Astra-Sim build scripts from a system-level path (/etc/astra-sim) to a repo-local path ("${SCRIPT_DIR:?}"/log), avoiding the need for sudo during directory creation.
Changes:
- Update
SIM_LOG_DIRin the top-levelastra-sim-alibabacloud/build.shto use a writable repo-locallog/directory. - Update
SIM_LOG_DIRinastra-sim-alibabacloud/build/astra_ns3/build.shto use a script-locallog/directory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| astra-sim-alibabacloud/build/astra_ns3/build.sh | Changes SIM_LOG_DIR away from /etc/astra-sim to avoid sudo-required paths in the ns3 build script. |
| astra-sim-alibabacloud/build.sh | Changes SIM_LOG_DIR away from /etc/astra-sim so the build creates log/input/result directories in a user-writable location. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…a-sim - export SIM_LOG_DIR from top-level build.sh so child scripts inherit it - ns3/build.sh inherits parent value or falls back to ../../log (same dir) - remove undefined BUILD_DIR cd that aborted compile function early - guard LOG_PATH and RESULT_PATH with #ifndef SIM_LOG_DIR; fall back to /etc/astra-sim when env var not set at cmake time - phynet/CMakeLists.txt injects -DSIM_LOG_DIR when env var is present Closes aliyun#254
Author
|
Use repo-local SIM_LOG_DIR, avoid sudo-required /etc/astra-sim
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #254